Skip to content

docs: Document BPF host routing incompatibility with Istio #38338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

docs: Document BPF host routing incompatibility with Istio #38338

merged 1 commit into from
Apr 3, 2025

Conversation

aditighag
Copy link
Member

@aditighag aditighag commented Mar 19, 2025 •
edited
Loading

Related to - #36022

Clayton Moss (clayton@cilium.io) verified that there were no issues with BPF masquerading with Istio.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 19, 2025
@aditighag aditighag added the release-note/misc This PR makes changes that have no direct user impact. label Mar 19, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 19, 2025
@julianwiedmann
Copy link
Member

Coming from #36022 - is the incompatibility with BPF Masquerade, or BPF Host Routing? If it's specifically BPF Host Routing, then we'd have a separate section for known limitations here.

@aditighag aditighag changed the title docs: Document BPF masquerading incompatibility with Istio docs: Document BPF host routing incompatibility with Istio Apr 2, 2025
@aditighag aditighag force-pushed the pr/aditighag/doc-bpf-masq-istio branch from da26734 to 52a8698 Compare April 2, 2025 17:30
@aditighag aditighag marked this pull request as ready for review April 2, 2025 17:30
@aditighag aditighag requested review from a team as code owners April 2, 2025 17:30
@aditighag
Copy link
Member Author

Coming from #36022 - is the incompatibility with BPF Masquerade, or BPF Host Routing? If it's specifically BPF Host Routing, then we'd have a separate section for known limitations here.

Good eye! It's BPF host routing that Istio is incompatible with per #36022. clay-moss confirmed that Istiod doesn't have issues with eBPF masquerading.

qmonnet
qmonnet approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Would it be worth linking to the GitHub issue, so that readers can follow progress if they want to?

@aditighag aditighag force-pushed the pr/aditighag/doc-bpf-masq-istio branch 2 times, most recently from 3ac522d to 20b03cf Compare April 3, 2025 14:28
@aditighag
Copy link
Member Author

/test

@aditighag
Copy link
Member Author

Looks good to me.

Would it be worth linking to the GitHub issue, so that readers can follow progress if they want to?

Hi @qmonnet :) Good idea -- done!

qmonnet
qmonnet requested changes Apr 3, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋🙂 I hope you're doing well!

Just a formatting nit below, can you update again please?

@aditighag
docs: Document BPF host routing incompatibility with Istio
c39be12 
Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag aditighag force-pushed the pr/aditighag/doc-bpf-masq-istio branch from 20b03cf to c39be12 Compare April 3, 2025 14:36
@aditighag
Copy link
Member Author

/test

qmonnet
qmonnet approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aditighag aditighag added this pull request to the merge queue Apr 3, 2025
Merged via the queue into cilium:main with commit a5ac7cb Apr 3, 2025
63 checks passed
@aditighag aditighag deleted the pr/aditighag/doc-bpf-masq-istio branch April 3, 2025 16:58
aditighag added a commit to aditighag/cilium that referenced this pull request May 12, 2025
@aditighag
docs: Revert incompatibility note with Istio
bff2f02 
Context - cilium#38338.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag aditighag mentioned this pull request May 12, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 15, 2025
@aditighag @qmonnet
docs: Revert incompatibility note with Istio
72465ef 
Context - #38338.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@YutaroHayakawa YutaroHayakawa Awaiting requested review from YutaroHayakawa YutaroHayakawa is a code owner automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditighag @julianwiedmann @qmonnet