Skip to content

feat(connectivity): add network bandwidth management test #38390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

l1b0k
Copy link
Contributor

@l1b0k l1b0k commented Mar 21, 2025

Related #36351

Fixes #26243

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 21, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary kind/community-contribution This was a contribution made by a community member. labels Mar 21, 2025
@l1b0k l1b0k force-pushed the feat/cli branch 3 times, most recently from 2b3a80d to bfb1f8a Compare April 11, 2025 03:45
@l1b0k l1b0k marked this pull request as ready for review April 11, 2025 04:00
@l1b0k l1b0k requested review from a team as code owners April 11, 2025 04:00
@l1b0k l1b0k requested review from thorn3r, brlbil and derailed April 11, 2025 04:00
@aditighag aditighag added the release-note/ci This PR makes changes to the CI. label Apr 18, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 18, 2025
@aditighag
Copy link
Member

Hi @l1b0k Thanks for your contribution. I've pinged the reviewers @thorn3r @derailed @brlbil. In the meantime, can you rebase the PR please?

Copy link
Contributor

@thorn3r thorn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Looks great, thank you!

Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l1b0k Nice! thank you for this update!

@marseel
Copy link
Contributor

marseel commented Apr 22, 2025

cc @hemanthmalla in case you want to take a look

@aanm
Copy link
Member

aanm commented Apr 29, 2025

/test

@aanm aanm enabled auto-merge April 29, 2025 08:26
Copy link
Member

@hemanthmalla hemanthmalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @l1b0k, It'd be great to trigger this as part of CI as well maybe in a different PR.

l1b0k added 2 commits May 8, 2025 11:59
Signed-off-by: l1b0k <libokang.dev@gmail.com>
- Add option to test pod network bandwidth management
- Implement bandwidth testing

Sample output from the test:

./cilium connectivity perf --bandwidth
ℹ️  Monitor aggregation detected, will skip some flow validation steps
🔥 [default] Deleting connectivity check deployments...
⌛ [default] Waiting for namespace cilium-test-1 to disappear
✨ [default] Creating namespace cilium-test-1 for connectivity check...
ℹ️  Nodes used for performance testing:
ℹ️  * Node name: izj6cfxlvfisad9dkdzmejz, zone:
ℹ️  * Node name: izj6cfxlvfisad9dkdzmekz, zone:
✨ [default] Deploying perf-server-egress deployment...
✨ [default] Deploying perf-server-ingress deployment...
✨ [default] Deploying perf-client-egress deployment...
✨ [default] Deploying perf-client-ingress deployment...
⌛ [default] Waiting for deployment cilium-test-1/perf-client-egress to become ready...
⌛ [default] Waiting for deployment cilium-test-1/perf-client-ingress to become ready...
⌛ [default] Waiting for deployment cilium-test-1/perf-server-egress to become ready...
⌛ [default] Waiting for deployment cilium-test-1/perf-server-ingress to become ready...
ℹ️  Cilium version: 1.18.0
🏃[cilium-test-1] Running 1 tests ...
[=] [cilium-test-1] Test [network-bandwidth-limit] [1/1]
..

ℹ️  cilium-test-1/perf-client-ingress-99c6c557-jvrzv : 10
ℹ️  cilium-test-1/perf-client-egress-575b846cf6-bngln : 9

✅ [cilium-test-1] All 1 tests (2 actions) successful, 0 tests skipped, 0 scenarios skipped.

Signed-off-by: l1b0k <libokang.dev@gmail.com>
@aanm
Copy link
Member

aanm commented May 8, 2025

/test

@julianwiedmann
Copy link
Member

looks like Birol is out. Could anyone else from @cilium/ci-structure cover the missing review? 🙏

@viktor-kurchenko viktor-kurchenko requested review from viktor-kurchenko and removed request for brlbil May 13, 2025 08:52
@aanm aanm added this pull request to the merge queue May 13, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2025
@pchaigno pchaigno added this pull request to the merge queue May 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue May 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue May 14, 2025
Merged via the queue into cilium:main with commit 3c6221c May 14, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-add Bandwidth Manager in CI
9 participants