Skip to content

cli: reverse finalizers of connectivity test #38232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

cli: reverse finalizers of connectivity test #38232

merged 1 commit into from
Mar 20, 2025
+4 −1

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Mar 17, 2025 •
edited
Loading

Previously, we were creating secrets and then policies in tests.
However, during teardown, we were removing secrets first and then
policies. This can result in transient issues, where policy references
non-existing secret if endpoint regeneration happens for whatever
reason.

Related: #37874

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 17, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Mar 17, 2025
@marseel
cli: reverse finalizers of connectivity test
864237e 
Previously, we were creating secrets and then policies in tests.
However, during teardown, we were removing secrets first and then
policies. This can result in transient issues, where policy references
non-existing secret if endpoint regeneration happens for whatever
reason.

Related: #37874

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the pr/marseel/reverse_cleanup_of_tests branch from 2428560 to 31f79e2 Compare March 17, 2025 14:20
@marseel
Copy link
Contributor Author

marseel commented Mar 17, 2025

/test

@marseel marseel force-pushed the pr/marseel/reverse_cleanup_of_tests branch from 31f79e2 to 864237e Compare March 19, 2025 11:45
@marseel marseel changed the title Pr/marseel/reverse cleanup of tests cli: reverse finalizers of connectivity test Mar 19, 2025
@marseel marseel added the release-note/ci This PR makes changes to the CI. label Mar 19, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 19, 2025
@marseel
Copy link
Contributor Author

marseel commented Mar 19, 2025

/test

@marseel marseel marked this pull request as ready for review March 19, 2025 14:47
@marseel marseel requested a review from a team as a code owner March 19, 2025 14:47
@marseel marseel requested a review from christarazi March 19, 2025 14:47
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 20, 2025
@tklauser tklauser added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 010cc55 Mar 20, 2025
218 of 220 checks passed
@tklauser tklauser deleted the pr/marseel/reverse_cleanup_of_tests branch March 20, 2025 05:38
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
@marseel marseel mentioned this pull request Apr 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marseel @christarazi @tklauser