nodemap: remove v1 map #38251
Merged
nodemap: remove v1 map #38251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bdb137 to
f97c310
Compare
julianwiedmann
commented
Mar 18, 2025
|
/test |
ldelossa
approved these changes
Mar 26, 2025
f97c310 to
4d121c4
Compare
|
/test |
|
This pull request has been automatically marked as stale because it |
|
This pull request has not seen any activity since it was marked stale. |
auto-merge was automatically disabled
May 10, 2025 02:05
Pull request was closed
7f72769 to
9b16620
Compare
cilium#31431 introduced v2 of the nodemap, and as of v1.16 the datapath only uses this v2 map. Hence it's safe to remove the agent logic that was still populating the v1 map. Fixes: cilium#34670 Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
9b16620 to
7f0be57
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31431 introduced v2 of the nodemap, and as of v1.16 the datapath only uses this v2 map. Hence it's safe to remove the agent logic that was still populating the v1 map.
Fixes: #34670