-
Notifications
You must be signed in to change notification settings - Fork 3.4k
datapath: provide node configuration at runtime #38244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test |
a3c85aa
to
6eb7d84
Compare
/test |
7ec4930
to
11b10c5
Compare
/test |
11b10c5
to
4a7dc99
Compare
/test |
4a7dc99
to
65d6c9c
Compare
/test |
65d6c9c
to
e38c236
Compare
/test |
e38c236
to
2ecb18c
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is simply amazing 😮 💯
Further additions to node_config.h will be rejected, assign to the work group overseeing the migration to runtime node configs. Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
2ecb18c
to
267381d
Compare
/test |
Like previous commits, this wraps an existing runtime-generated config header to gradually migrate node configs to. Also converged on 'lnc' for the variable name for LocalNodeConfiguration, since we now sometimes have more than a few config-related structs in a given function. Signed-off-by: Timo Beckers <timo@isovalent.com>
267381d
to
308b9e7
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Please find some suggestions on the docs below, none blocking
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
The preceding changes to dpgen allowed for removing the _1/_2 hack to stitch a MAC address together. Added MAC.As8() to help with converting the slice to an array. For historical reasons, union macaddr is 8 bytes and we can't turn it into 6 bytes since it's used as a map value. Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
308b9e7
to
1abd006
Compare
/test |
Nice! Good to see this landing. |
This PR adds a
config.Node
BPF configuration object and embeds it into existingBPFLXC
,BPFHost
etc. configs.This configuration is currently generated based on
option.Config
andLocalNodeConfiguration
, but will eventually integrate with Hive.