Skip to content

Conversation

ti-mo
Copy link
Contributor

@ti-mo ti-mo commented Mar 17, 2025

This PR adds a config.Node BPF configuration object and embeds it into existing BPFLXC, BPFHost etc. configs.

This configuration is currently generated based on option.Config and LocalNodeConfiguration, but will eventually integrate with Hive.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 17, 2025
@ti-mo ti-mo added the release-note/misc This PR makes changes that have no direct user impact. label Mar 17, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 17, 2025
@ti-mo
Copy link
Contributor Author

ti-mo commented Mar 17, 2025

/test

@ti-mo ti-mo force-pushed the tb/datapath-node-config-struct branch from a3c85aa to 6eb7d84 Compare March 18, 2025 13:22
@ti-mo
Copy link
Contributor Author

ti-mo commented Mar 18, 2025

/test

@ti-mo ti-mo force-pushed the tb/datapath-node-config-struct branch 2 times, most recently from 7ec4930 to 11b10c5 Compare March 19, 2025 16:34
@ti-mo
Copy link
Contributor Author

ti-mo commented Mar 19, 2025

/test

@ti-mo ti-mo force-pushed the tb/datapath-node-config-struct branch from 11b10c5 to 4a7dc99 Compare March 20, 2025 11:23
@ti-mo
Copy link
Contributor Author

ti-mo commented Mar 20, 2025

/test

@ti-mo ti-mo force-pushed the tb/datapath-node-config-struct branch from 4a7dc99 to 65d6c9c Compare March 20, 2025 13:02
@ti-mo
Copy link
Contributor Author

ti-mo commented Mar 20, 2025

/test

@ti-mo ti-mo force-pushed the tb/datapath-node-config-struct branch from 65d6c9c to e38c236 Compare March 20, 2025 13:13
@ti-mo
Copy link
Contributor Author

ti-mo commented Mar 20, 2025

/test

@ti-mo ti-mo force-pushed the tb/datapath-node-config-struct branch from e38c236 to 2ecb18c Compare March 20, 2025 13:16
@ti-mo
Copy link
Contributor Author

ti-mo commented Mar 20, 2025

/test

@ti-mo ti-mo marked this pull request as ready for review March 20, 2025 14:41
@ti-mo ti-mo requested review from a team as code owners March 20, 2025 14:41
Copy link
Contributor

@smagnani96 smagnani96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simply amazing 😮 💯

ti-mo added 2 commits March 25, 2025 15:13
Further additions to node_config.h will be rejected, assign to the
work group overseeing the migration to runtime node configs.

Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo force-pushed the tb/datapath-node-config-struct branch from 2ecb18c to 267381d Compare March 25, 2025 14:13
@ti-mo ti-mo requested a review from a team as a code owner March 25, 2025 14:13
@ti-mo ti-mo requested a review from qmonnet March 25, 2025 14:13
@ti-mo
Copy link
Contributor Author

ti-mo commented Mar 25, 2025

/test

Like previous commits, this wraps an existing runtime-generated config header
to gradually migrate node configs to.

Also converged on 'lnc' for the variable name for LocalNodeConfiguration,
since we now sometimes have more than a few config-related structs in a given
function.

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo force-pushed the tb/datapath-node-config-struct branch from 267381d to 308b9e7 Compare March 25, 2025 14:21
@ti-mo
Copy link
Contributor Author

ti-mo commented Mar 25, 2025

/test

Copy link
Contributor

@rgo3 rgo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Please find some suggestions on the docs below, none blocking

ti-mo added 7 commits March 26, 2025 11:11
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
The preceding changes to dpgen allowed for removing the _1/_2 hack to stitch
a MAC address together. Added MAC.As8() to help with converting the slice to
an array.

For historical reasons, union macaddr is 8 bytes and we can't turn it into 6
bytes since it's used as a map value.

Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo force-pushed the tb/datapath-node-config-struct branch from 308b9e7 to 1abd006 Compare March 26, 2025 10:11
@ti-mo
Copy link
Contributor Author

ti-mo commented Mar 26, 2025

/test

@ti-mo ti-mo enabled auto-merge March 26, 2025 14:41
@jrife
Copy link
Contributor

jrife commented Mar 26, 2025

Nice! Good to see this landing.

@ti-mo ti-mo added this pull request to the merge queue Mar 27, 2025
Merged via the queue into cilium:main with commit d4dcc2d Mar 27, 2025
66 of 67 checks passed
@ti-mo ti-mo deleted the tb/datapath-node-config-struct branch March 27, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants