cli: Reduce the flood of the terminal with logs on failure during tests #38240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
158d3d9 to
f16c3c1
Compare
|
PTAL @joestringer |
joestringer
approved these changes
Mar 17, 2025
|
/test |
|
The BPF Checks workflow is a bit grumpy about the commit subject line, but I think it's plenty descriptive so I don't see a need to change anything to address that. I've triggered the broader testsuite. |
asauber
approved these changes
Mar 19, 2025
auto-merge was automatically disabled
March 19, 2025 12:02
Head branch was pushed to by a user without write access
5d10e99 to
dbb9b92
Compare
Return only valuable (err, warn, fatal) messages in case of verbose enabled all the messages will returned. Fixes cilium#38182 Signed-off-by: roman-kiselenko <roman.kiselenko.dev@gmail.com>
dbb9b92 to
9d5e3ac
Compare
|
/test |
|
I'm unsure if the failing tests relate to my changes, but it looks suspicious 🤷 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t setup/teardown
Return only valuable (err, warn, fatal) messages in case of verbose enabled all the messages will returned.
Fixes #38182
Based on #37160