cilium-cli: Allow running outside the Cilium tree #38133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last change in this area baked in a hard expectation that the CLI is run inside the Cilium tree, but this doesn't make sense. Relax it so the code owners are only loaded when --log-code-owners is passed on the command line. Fixes: a7f4ba1 ("cli: Load code owners dynamically via --code-owners") Reported-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Joe Stringer <joe@cilium.io>
4d173a0 to
edf6f31
Compare
|
/test |
michi-covalent
approved these changes
Mar 11, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last change in this area baked in a hard expectation that the CLI is
run inside the Cilium tree, but this doesn't make sense. Relax it so the
code owners are only loaded when --log-code-owners is passed on the
command line.
Fixes: a7f4ba1 ("cli: Load code owners dynamically via --code-owners")
Reported-by: @giorio94