bpf: tolerate dropped ICMPv6 messages with ICMPv6 payload #38068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same reasoning as in d7375c5 ("connectivity: add unknown ICMPv4 code as expected drop reason"). Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Allow the CLI connectivity tests to tolerate drops of ICMPv6 error messages with an ICMPv6 payload. These are most likely caused a ping to a non-existent address, which then is returned with an `DestinationUnreachable(AddressUnreachable)` ICMPv6 error message. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
|
/test |
joamaki
approved these changes
Mar 7, 2025
mhofstetter
approved these changes
Mar 7, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bit of polish for #37766, until we have proper SNAT support for ICMPv6 messages with ICMPv6 payload.
This allows us to filter out such "known" gaps in the CLI connectivity tests.