Skip to content

connectivity: Add test for source egress in Ingress #38053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Mar 7, 2025

No description provided.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 7, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Mar 7, 2025
@sayboras sayboras added the release-note/ci This PR makes changes to the CI. label Mar 7, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 7, 2025
@sayboras sayboras requested a review from jrajahalme March 7, 2025 04:20
@sayboras sayboras marked this pull request as ready for review March 7, 2025 04:23
@sayboras sayboras requested a review from a team as a code owner March 7, 2025 04:23
@sayboras sayboras requested a review from christarazi March 7, 2025 04:23
@sayboras
Copy link
Member Author

sayboras commented Mar 7, 2025

/test

@sayboras sayboras marked this pull request as draft March 7, 2025 08:44
It's easier to maintain all related tests if they are in the same file.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/ingress-connectivity branch 2 times, most recently from 4f66e22 to 6735de5 Compare March 7, 2025 10:42
This test will cover both positive and negative cases:

- Request from any client pods to cilium-ingress-same-node will be
  allowed.
- Request from any client pods to cilium-ingress-other-node will be
  denied.

Relates: cilium/proxy#1172
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/ingress-connectivity branch from 6735de5 to 33ec42c Compare March 7, 2025 11:31
@sayboras sayboras marked this pull request as ready for review March 7, 2025 11:37
@sayboras
Copy link
Member Author

sayboras commented Mar 7, 2025

/test

@sayboras sayboras added this pull request to the merge queue Mar 12, 2025
@sayboras
Copy link
Member Author

Merged after verify that new test was running successfully

https://github.com/cilium/cilium/actions/runs/13730599919/job/38406756418

[=] [cilium-test-4] Test [pod-to-ingress-service-deny-source-egress-other-node] [21/23]
......
[=] [cilium-test-4] Skipping test [pod-to-k8s-on-controlplane] [22/23] (skipped by condition)
[=] [cilium-test-4] Test [pod-to-pod-no-frag] [23/23]

Merged via the queue into main with commit 212c228 Mar 12, 2025
216 checks passed
@sayboras sayboras deleted the pr/tammach/ingress-connectivity branch March 12, 2025 12:04
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants