-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Centralize dynamic test ownership configuration #38045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d74c84
to
0ddba9a
Compare
e73bb75
to
4568bab
Compare
0ddba9a
to
fec2ee0
Compare
4568bab
to
0a847b4
Compare
/test |
Move all of these to one location to reduce the number of places the flags are declared and to align the declarations with the way that other workflows declare CLI flags. Signed-off-by: Joe Stringer <joe@cilium.io>
By placing this configuration in the central env variables declarations, we can update all of these commands from one place when backporting this change to stable branches (where the stable branch will have a different file to define the path to the CODEOWNERS file for attributing test failures to owners). Signed-off-by: Joe Stringer <joe@cilium.io>
59d4e61
to
217b9f4
Compare
/test |
/test |
@christarazi @brlbil @youngnick @jrajahalme gentle ping for review, this should be a simple one 😇 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makefile.defs good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm for clustermesh.
This PR contains the workflow and makefile changes necessary for us to
configure new and different CODEOWNERS-style files for test ownership,
particularly for older stable branches of Cilium. See #38044 for more
background.