Skip to content

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Mar 6, 2025

This PR contains the workflow and makefile changes necessary for us to
configure new and different CODEOWNERS-style files for test ownership,
particularly for older stable branches of Cilium. See #38044 for more
background.

@joestringer joestringer added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. backport/author The backport will be carried out by the author of the PR. needs-backport/1.15 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Mar 6, 2025
@joestringer joestringer force-pushed the pr/joe/code-owners-files branch from 2d74c84 to 0ddba9a Compare March 6, 2025 23:44
@joestringer joestringer force-pushed the pr/joe/code-owners-workflows branch from e73bb75 to 4568bab Compare March 6, 2025 23:44
@joestringer joestringer force-pushed the pr/joe/code-owners-files branch from 0ddba9a to fec2ee0 Compare March 6, 2025 23:58
@joestringer joestringer force-pushed the pr/joe/code-owners-workflows branch from 4568bab to 0a847b4 Compare March 6, 2025 23:58
@joestringer
Copy link
Member Author

/test

Base automatically changed from pr/joe/code-owners-files to main March 7, 2025 22:28
@joestringer joestringer marked this pull request as ready for review March 7, 2025 22:29
@joestringer joestringer requested review from a team as code owners March 7, 2025 22:29
Move all of these to one location to reduce the number of places the
flags are declared and to align the declarations with the way that other
workflows declare CLI flags.

Signed-off-by: Joe Stringer <joe@cilium.io>
By placing this configuration in the central env variables declarations,
we can update all of these commands from one place when backporting this
change to stable branches (where the stable branch will have a different
file to define the path to the CODEOWNERS file for attributing test
failures to owners).

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the pr/joe/code-owners-workflows branch from 59d4e61 to 217b9f4 Compare March 11, 2025 21:03
@joestringer
Copy link
Member Author

/test

auto-merge was automatically disabled March 11, 2025 21:38

Pull request was closed

@joestringer joestringer reopened this Mar 11, 2025
@joestringer
Copy link
Member Author

/test

@joestringer
Copy link
Member Author

@christarazi @brlbil @youngnick @jrajahalme gentle ping for review, this should be a simple one 😇 🙏

Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makefile.defs good

Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm for clustermesh.

@joestringer joestringer added this pull request to the merge queue Mar 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2025
@joestringer joestringer added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 2263c02 Mar 13, 2025
473 of 549 checks passed
@joestringer joestringer deleted the pr/joe/code-owners-workflows branch March 13, 2025 16:10
@joestringer joestringer added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Aug 7, 2025
@joestringer joestringer added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Aug 12, 2025
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport/author The backport will be carried out by the author of the PR. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants