cli: Clean up Makefile #37911
Merged
cli: Clean up Makefile #37911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
- Include the top-level Makefile.defs, and re-use GO and INSTALL variables. - Remove unused THIS_DIR variable [^1]. - Explicitly set BINDIR and GO_BUILD_LDFLAGS variable. Cilium and Cilium CLI use different values for these settings. [^1]: #36344 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
083a5a0 to
6b7a375
Compare
|
/test |
tklauser
approved these changes
Feb 28, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Footnotes
https://github.com/cilium/cilium/pull/36344 ↩