-
Notifications
You must be signed in to change notification settings - Fork 3.4k
cli: Support filtering --log-code-owners #37905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test |
c30c741
to
39bd3d7
Compare
/test |
wedaly
approved these changes
Feb 27, 2025
michi-covalent
approved these changes
Feb 27, 2025
christarazi
approved these changes
Feb 27, 2025
mhofstetter
approved these changes
Feb 28, 2025
giorio94
approved these changes
Feb 28, 2025
aanm
approved these changes
Feb 28, 2025
The defaults to exclude cilium/github-sec make sense, but it can be useful to exclude other code owners on demand. Make a (hidden) configurable flag for the list of these owners, --exclude-code-owners. Signed-off-by: Joe Stringer <joe@cilium.io>
Move the codeowner logging to the default configurations. No functional change intended. Signed-off-by: Joe Stringer <joe@cilium.io>
39bd3d7
to
725ee95
Compare
Rebased to address conflict vs. main. |
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-done/1.16
The backport for Cilium 1.16.x for this PR is done.
backport-done/1.17
The backport for Cilium 1.17.x for this PR is done.
cilium-cli
This PR contains changes related with cilium-cli
cilium-cli-exclusive
This PR only impacts cilium-cli binary
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaults to exclude cilium/github-sec make sense, but it can be
useful to exclude other code owners on demand. Make a (hidden)
configurable flag for the list of these owners,
--exclude-code-owners
.