Skip to content

Conversation

joestringer
Copy link
Member

The defaults to exclude cilium/github-sec make sense, but it can be
useful to exclude other code owners on demand. Make a (hidden)
configurable flag for the list of these owners, --exclude-code-owners.

@joestringer joestringer requested review from a team as code owners February 27, 2025 18:31
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Feb 27, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Feb 27, 2025
@joestringer
Copy link
Member Author

/test

@joestringer joestringer force-pushed the pr/joe/cli-exclude-codeowners branch from c30c741 to 39bd3d7 Compare February 27, 2025 19:54
@joestringer joestringer requested review from a team as code owners February 27, 2025 19:54
@joestringer
Copy link
Member Author

/test

@aanm aanm enabled auto-merge February 28, 2025 08:01
@joestringer joestringer removed the request for review from derailed February 28, 2025 18:39
The defaults to exclude cilium/github-sec make sense, but it can be
useful to exclude other code owners on demand. Make a (hidden)
configurable flag for the list of these owners, --exclude-code-owners.

Signed-off-by: Joe Stringer <joe@cilium.io>
Move the codeowner logging to the default configurations. No functional
change intended.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the pr/joe/cli-exclude-codeowners branch from 39bd3d7 to 725ee95 Compare February 28, 2025 18:44
@joestringer
Copy link
Member Author

Rebased to address conflict vs. main.

@joestringer
Copy link
Member Author

/test

@aanm aanm added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 09e343d Feb 28, 2025
287 checks passed
@aanm aanm deleted the pr/joe/cli-exclude-codeowners branch February 28, 2025 22:46
@joestringer joestringer added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Aug 7, 2025
@joestringer joestringer added the backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. label Aug 12, 2025
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants