Skip to content

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Mar 4, 2025

Since #37076 was merged we have a new mode of synchronizing TLS secrets to Envoy. Previously we used NPDS, while new way uses SDS. However, by setting secretsBackend=k8s we were forcing old behaviour. Let's start testing SDS as it's a new default.

Most likely fixes #37874

Since #37076 was merged we have a new mode of synchronizing TLS secrets
to Envoy. Previously we used NPDS, while new way uses SDS. However, by
setting secretsBackend=k8s we were forcing old behaviour.
Let's start testing SDS as it's a new default.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 4, 2025
@marseel
Copy link
Contributor Author

marseel commented Mar 4, 2025

/ci-aks

@marseel
Copy link
Contributor Author

marseel commented Mar 4, 2025

/ci-eks

@marseel
Copy link
Contributor Author

marseel commented Mar 4, 2025

/ci-gke

@marseel marseel added the release-note/ci This PR makes changes to the CI. label Mar 4, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 4, 2025
@marseel
Copy link
Contributor Author

marseel commented Mar 4, 2025

/test

@marseel marseel marked this pull request as ready for review March 4, 2025 17:24
@marseel marseel requested review from a team as code owners March 4, 2025 17:24
@marseel
Copy link
Contributor Author

marseel commented Mar 4, 2025

cc @cilium/sig-servicemesh

Copy link
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, SDS is a vast improvement over passing Secrets inline in NPDS, so I'm very happy to see us exercising that code more in CI.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 5, 2025
@julianwiedmann julianwiedmann added the integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. label Mar 6, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit 452a0bf Mar 6, 2025
112 checks passed
@julianwiedmann julianwiedmann deleted the pr/marseel/enable_sds branch March 6, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Conformance AKS (ci-aks) - secrets not found
6 participants