cilium-cli/connectivity: only check container restarts on v1.17+ #37823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f900d93 ("cilium-cli/connectivity: additionally check for container restarts") introduced a new check to the connectivity suite to validate that no Cilium-related pods have a container restart count greater than zero. However, this check is getting triggered way more than expected on older stable branches. Let's temporarily enable it only for Cilium v1.17 and later, while the discovered failures get investigated. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
jschwinger233
approved these changes
Feb 24, 2025
bimmlerd
approved these changes
Feb 24, 2025
auto-merge was automatically disabled
February 25, 2025 15:18
Pull Request is not mergeable
Opened #37870 to track the problem detected on v1.16. I didn't open one for the issue detected by the v1.15 CI as it was occurring on downgrade, and v1.14 is EOL. |
1 task
julianwiedmann
added a commit
that referenced
this pull request
Mar 5, 2025
This reverts commit 6e80cf2. This version of the CLI still has the problem described in #37823 (comment) and is thus causing flakes in CI. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added a commit
that referenced
this pull request
Mar 5, 2025
This reverts commit 6e80cf2. This version of the CLI still has the problem described in #37823 (comment) and is thus causing flakes in CI. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f900d93 ("cilium-cli/connectivity: additionally check for container restarts") introduced a new check to the connectivity suite to validate that no Cilium-related pods have a container restart count greater than zero. However, this check is getting triggered way more than expected on older stable branches. Let's temporarily enable it only for Cilium v1.17 and later, while the discovered failures get investigated.