Skip to content

cli: connectivity: Log tcpdump cmd on error #37822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

cli: connectivity: Log tcpdump cmd on error #37822

merged 1 commit into from
Feb 27, 2025

Conversation

jschwinger233
Copy link
Member

This can help #37784

@jschwinger233
cli: connectivity: Log tcpdump cmd on error
ee20824 
Signed-off-by: gray <gray.liang@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 24, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Feb 24, 2025
@jschwinger233 jschwinger233 added release-note/ci This PR makes changes to the CI. cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Feb 24, 2025
@jschwinger233 jschwinger233 mentioned this pull request Feb 24, 2025
Closed
@jschwinger233
Copy link
Member Author

/test

@joestringer
Copy link
Member

Can we help unblock this?

@jschwinger233
Copy link
Member Author

Can we help unblock this?

Yes please. What can I do to pass ci-awscni? The error doesn't seem to be relevant to my change?

@joestringer
Copy link
Member

AWS-CNI is not required to merge. I think we just need review? Marking it ready.

@joestringer joestringer marked this pull request as ready for review February 27, 2025 16:12
@joestringer joestringer requested a review from a team as a code owner February 27, 2025 16:12
@joestringer joestringer merged commit 4d4307c into main Feb 27, 2025
213 of 216 checks passed
@joestringer joestringer deleted the pr/gray/sniffer-log-cmd-on-error branch February 27, 2025 16:12
@sypakine sypakine mentioned this pull request Feb 27, 2025
Closed
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@christarazi christarazi Awaiting requested review from christarazi christarazi is a code owner automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschwinger233 @joestringer