cilium-cli: Only use --curl-parallel when expecting success #37803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused function CurlCommandParallelWithOutput. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Rename CurlCommand as CurlCommandWithOutput and remove the output disabling options from it. Implement CurlCommand by calling CurlCommandWithOutput with extra options to disable output. This also makes explicit "-4" option on CurlCommandWithOutput unnecessary when the IPFamily is passed in as IPFamilyV4. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
Only use `--curl-parallel` on curl commands that are expected to succeed. When expecting failure and issuing parallel requests, curl will report failure if any of the parallel requests fail, thus possibly hiding unexpectedly succeeding requests. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
|
/test |
Artyop
approved these changes
Feb 21, 2025
rastislavs
approved these changes
Feb 21, 2025
bimmlerd
approved these changes
Feb 24, 2025
sayboras
approved these changes
Feb 24, 2025
ysksuzuki
approved these changes
Feb 25, 2025
smagnani96
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use
--curl-parallelon curl commands that are expected to succeed. When expecting failure and issuing parallel requests, curl will report failure if any of the parallel requests fail, thus possibly hiding unexpectedly succeeding requests.