Skip to content

bgpv1: wait for watchers to be ready in tests #37884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

bgpv1: wait for watchers to be ready in tests #37884

merged 1 commit into from
Feb 27, 2025

Conversation

harsimran-pabla
Copy link
Contributor

@harsimran-pabla harsimran-pabla commented Feb 26, 2025 •
edited
Loading

Introduce ready callback method in tests which checks that all expected watchers are initialized properly.

With this change

3m55s: 1724 runs so far, 0 failures
4m0s: 1762 runs so far, 0 failures

WIthout this change

4m10s: 1784 runs so far, 2 failures (0.11%)
4m15s: 1824 runs so far, 2 failures (0.11%)

Main symptom of the issue is missing peer in Cilium,

working case

time="2025-02-26T21:12:55.270568103Z" level=info msg="Cilium BGP Control Plane Controller now running..." component=Controller.Run subsys=bgp-control-plane
time="2025-02-26T21:12:55.270986361Z" level=info msg="Registering BGP servers for policy with local ASN 65001" component=manager.registerBGPServer subsys=bgp-control-plane
time="2025-02-26T21:12:55.271844878Z" level=info msg="Adding peer 172.16.100.2/32 65011 to local ASN 65001" component=NeighborReconciler subsys=bgp-control-plane
time="2025-02-26T21:12:55.272004464Z" level=info msg="Add a peer configuration" Key=172.16.100.2 Topic=Peer asn=65001 component=gobgp.BgpServerInstance subsys=bgp-control-plane
time="2025-02-26T21:12:55.272177843Z" level=info msg="Successfully registered GoBGP servers for policy with local ASN 65001" component=manager.registerBGPServer subsys=bgp-control-plane

non-working case, we skip adding peer.

time="2025-02-26T20:41:50.81480455Z" level=info msg="Cilium BGP Control Plane Controller now running..." component=Controller.Run subsys=bgp-control-plane
time="2025-02-26T20:41:50.814996428Z" level=info msg="Registering BGP servers for policy with local ASN 65001" component=manager.registerBGPServer subsys=bgp-control-plane
time="2025-02-26T20:41:50.81528835Z" level=info msg="Successfully registered GoBGP servers for policy with local ASN 65001" component=manager.registerBGPServer subsys=bgp-control-plane

Fixes: #35607

@harsimran-pabla
bgpv1: wait for watchers to be ready in tests
be48b06 
Introduce ready callback method in tests which checks that all expected
watchers are initialized properly.

Fixes: cilium#35607

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 26, 2025
@harsimran-pabla harsimran-pabla added the release-note/misc This PR makes changes that have no direct user impact. label Feb 26, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 26, 2025
@harsimran-pabla harsimran-pabla added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. area/bgp Impacts the Border Gateway Protocol feature. labels Feb 26, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 26, 2025
@rastislavs
Copy link
Contributor

/test

rastislavs
rastislavs reviewed Feb 27, 2025
View reviewed changes
@harsimran-pabla harsimran-pabla marked this pull request as ready for review February 27, 2025 13:39
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner February 27, 2025 13:39
@harsimran-pabla harsimran-pabla added needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch kind/bug/CI This is a bug in the testing code. labels Feb 27, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 27, 2025
@julianwiedmann julianwiedmann added release-note/ci This PR makes changes to the CI. and removed release-note/misc This PR makes changes that have no direct user impact. labels Feb 27, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue Feb 27, 2025
Merged via the queue into cilium:main with commit 1f0e895 Feb 27, 2025
64 of 65 checks passed
@nbusseneau nbusseneau mentioned this pull request Feb 27, 2025
Merged
17 tasks
@nbusseneau nbusseneau added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Feb 27, 2025
@joamaki joamaki mentioned this pull request Mar 5, 2025
Merged
4 tasks
@joamaki joamaki added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Mar 5, 2025
@github-actions github-actions bot removed the backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. label Mar 6, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rastislavs rastislavs rastislavs approved these changes

Assignees
No one assigned
Labels
area/bgp Impacts the Border Gateway Protocol feature. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. kind/bug/CI This is a bug in the testing code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Runtime Test (privileged) - Test_PodIPPoolAdvert
5 participants
@harsimran-pabla @rastislavs @joamaki @nbusseneau @julianwiedmann