cec: support for explicit control of Cilium Policy enforcement Envoy filter injection #37868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffcce63 to
d1fa8dc
Compare
This commit places the decision whether upstream Cilium Envoy filters should be injected closer to the place where the downstream Cilium Envoy filter decision is made. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
d1fa8dc to
d18897c
Compare
d18897c to
78b90b8
Compare
Currently, the Cilium Envoy network- and L7 filters are always automatically injected when the CiliumEnvoyConfig is used for L7LB (parameter `isL7LB` - that is set to true when `Spec.Services` are defined on the CEC). This commit adds the possibility for a more explicit configuration of this behaviour by adding the annotation `cec.cilium.io/inject-cilium-filters`. If the annotation is present on the `CiliumEnvoyConfig` it is used to decide whether Cilium Envoy filters should be automatically injected or not. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
78b90b8 to
ba7d4e3
Compare
|
/test |
christarazi
approved these changes
Mar 4, 2025
mhofstetter
added a commit
to mhofstetter/cilium
that referenced
this pull request
Apr 24, 2025
PR cilium#37868 introduced the possibility to control Cilium Envoy filter injection via annotation. But the PR missed one occurrence that is still only checking for `len(spec.Services) > 0` instead of calling `injectCiliumEnvoyFilters`. This commit fixes this. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added a commit
to mhofstetter/cilium
that referenced
this pull request
Apr 30, 2025
PR cilium#37868 introduced the possibility to control Cilium Envoy filter injection via annotation. But the PR missed one occurrence that is still only checking for `len(spec.Services) > 0` instead of calling `injectCiliumEnvoyFilters`. This commit fixes this. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 5, 2025
PR #37868 introduced the possibility to control Cilium Envoy filter injection via annotation. But the PR missed one occurrence that is still only checking for `len(spec.Services) > 0` instead of calling `injectCiliumEnvoyFilters`. This commit fixes this. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
hsalluri259
pushed a commit
to hsalluri259/cilium
that referenced
this pull request
May 14, 2025
PR cilium#37868 introduced the possibility to control Cilium Envoy filter injection via annotation. But the PR missed one occurrence that is still only checking for `len(spec.Services) > 0` instead of calling `injectCiliumEnvoyFilters`. This commit fixes this. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Cilium Envoy network- and L7 policy enforcement filters are always automatically
injected when the
CiliumEnvoyConfigis used for L7LB (parameterisL7LB- thatis set to true when
Spec.Servicesare defined on the CEC).This commit adds the possibility for a more explicit configuration of this
behaviour by adding the annotation
cec.cilium.io/inject-cilium-filters.If the annotation is present on the
CiliumEnvoyConfigit is used to decidewhether Cilium Envoy filters should be automatically injected or not.