cilium-cli: re-fix GITHUB_WORKFLOW_REF parsing #37707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af9ac19 introduced an issue where the cilium-cli connectivity check could panic when GITHUB_WORKFLOW_REF was not set as expected. This commit changes the GITHUB_WORKFLOW_REF parsing logic using a regexp capture to extract the workflow name from GITHUB_WORKFLOW_REF and check whether the match was successful. Reported-by: Martynas Pumputis <martynas@isovalent.com> Signed-off-by: Alexandre Perrin <alex@isovalent.com>
ac38918 to
5d03fab
Compare
|
/test |
joestringer
reviewed
Feb 18, 2025
joestringer
approved these changes
Feb 18, 2025
viktor-kurchenko
approved these changes
Feb 18, 2025
|
We're even lucky enough to get a random failure in ci-clustermesh that demonstrates that this fixes the issue that was reported, as in the case where GITHUB_WORKFLOW_REF is unspecified it just ignores the workflow attribution rather than crashing: https://github.com/cilium/cilium/actions/runs/13392927898/job/37404692001#step:54:463 🎉 |
|
Hit #37718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
af9ac19 introduced an issue where the cilium-cli connectivity check could panic when
GITHUB_WORKFLOW_REFwas not set as expected.This commit changes the
GITHUB_WORKFLOW_REFparsing logic using a regexp capture to extract the workflow name fromGITHUB_WORKFLOW_REFand check whether the match was successful.Fix #37705