Skip to content

ci-aks: Enable dual-stack in Conformance AKS #37704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2025
Merged

ci-aks: Enable dual-stack in Conformance AKS #37704

merged 2 commits into from
Feb 19, 2025

Conversation

gandro
Copy link
Member

@gandro gandro commented Feb 18, 2025 •
edited
Loading

This commit enables dual-stack in both the created AKS cluster as well as in Cilium CNI. This ensures that we are testing BYOCNI with dual-stack, which is a supported configuration after all.

Fixes: #37142

@gandro gandro added the release-note/ci This PR makes changes to the CI. label Feb 18, 2025
@gandro
Copy link
Member Author

gandro commented Feb 18, 2025 •
edited
Loading

/ci-aks

✔️ https://github.com/cilium/cilium/actions/runs/13390597115/job/37397280550

@gandro
Copy link
Member Author

gandro commented Feb 18, 2025 •
edited
Loading

/ci-aks

✔️ https://github.com/cilium/cilium/actions/runs/13393592813

@gandro gandro force-pushed the pr/gandro/aks-ci-dual-stack branch from 963b5b1 to 2912e33 Compare February 18, 2025 16:27
@gandro
Copy link
Member Author

gandro commented Feb 18, 2025 •
edited
Loading

/ci-aks

✔️ https://github.com/cilium/cilium/actions/runs/13395710793/job/37415052673

@gandro
ci-aks: Enable dual-stack in Conformance AKS
d206fc7 
This commit enables dual-stack in both the created AKS cluster as well
as in Cilium CNI. This ensures that we are testing BYOCNI with
dual-stack, which is a supported configuration after all.

Fixes: #37142

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro
ci-aks: Run connectivity tests concurrently
e61565d 
This should reduce the overall execution time of the workflow.

Suggested-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro force-pushed the pr/gandro/aks-ci-dual-stack branch from 2de8aca to e61565d Compare February 19, 2025 10:22
@gandro
Copy link
Member Author

gandro commented Feb 19, 2025

/ci-aks

@gandro
Copy link
Member Author

gandro commented Feb 19, 2025

/test

@gandro gandro marked this pull request as ready for review February 19, 2025 10:23
@gandro gandro requested review from a team as code owners February 19, 2025 10:23
viktor-kurchenko
viktor-kurchenko reviewed Feb 19, 2025
View reviewed changes
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 19, 2025
@gandro gandro removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 19, 2025
@gandro
Copy link
Member Author

gandro commented Feb 19, 2025

Let's wait for CI to be green before we merge this 😅

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 19, 2025
@gandro gandro added dont-merge/bad-bot To prevent MLH from marking ready-to-merge. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. dont-merge/bad-bot To prevent MLH from marking ready-to-merge. labels Feb 19, 2025
@gandro gandro added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit e02ec08 Feb 19, 2025
76 checks passed
@gandro gandro deleted the pr/gandro/aks-ci-dual-stack branch February 19, 2025 11:11
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 19, 2025
julianwiedmann added a commit that referenced this pull request Feb 27, 2025
@julianwiedmann
gh: ipsec-e2e: add concurrency for connectivity tests
d0032c0 
Inspired by #34806 and
#37704, enable concurrent execution
when running the connectivity tests. This substantially reduces the
workflow's runtime.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann mentioned this pull request Feb 27, 2025
Merged
julianwiedmann added a commit that referenced this pull request Feb 27, 2025
@julianwiedmann
gh: ipsec-e2e: add concurrency for connectivity tests
4c82eee 
Inspired by #34806 and
#37704, enable concurrent execution
when running the connectivity tests. This substantially reduces the
workflow's runtime.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Feb 28, 2025
@julianwiedmann
gh: ipsec-e2e: add concurrency for connectivity tests
6bf3a14 
Inspired by #34806 and
#37704, enable concurrent execution
when running the connectivity tests. This substantially reduces the
workflow's runtime.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann added a commit that referenced this pull request Feb 28, 2025
@julianwiedmann
gh: ipsec-e2e: add concurrency for connectivity tests
fca5ab0 
[ upstream commit 6bf3a14 ]

Inspired by #34806 and
#37704, enable concurrent execution
when running the connectivity tests. This substantially reduces the
workflow's runtime.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 3, 2025
@julianwiedmann @aanm
gh: ipsec-e2e: add concurrency for connectivity tests
a63e973 
[ upstream commit 6bf3a14 ]

Inspired by #34806 and
#37704, enable concurrent execution
when running the connectivity tests. This substantially reduces the
workflow's runtime.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added the feature/ipv6 Relates to IPv6 protocol support label Apr 3, 2025
@julianwiedmann julianwiedmann added the needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch label May 5, 2025
@sayboras sayboras mentioned this pull request May 7, 2025
Merged
9 tasks
@sayboras sayboras added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels May 7, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. feature/ipv6 Relates to IPv6 protocol support ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the conformance-aks workflow DualStack enabled
4 participants
@gandro @viktor-kurchenko @sayboras @julianwiedmann