Skip to content

Update connectivity tests to correctly detect TLS Interception #37796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

Update connectivity tests to correctly detect TLS Interception #37796

merged 1 commit into from
Feb 24, 2025

Conversation

youngnick
Copy link
Contributor

The existing connectivity tests were using the old PolicySecretsBackendK8s feature to detect if TLS Interception was in use, this fixes those tests to use the new
PolicySecretsOnlyFromSecretsNamespace feature instead.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@youngnick
Update connectivity tests to correctly detect TLS Interception
a635a70 
The existing connectivity tests were using the old
PolicySecretsBackendK8s feature to detect if TLS Interception was
in use, this fixes those tests to use the new
PolicySecretsOnlyFromSecretsNamespace feature instead.

Signed-off-by: Nick Young <nick@isovalent.com>
@youngnick youngnick requested review from a team as code owners February 21, 2025 04:28
@youngnick youngnick requested review from Artyop and asauber February 21, 2025 04:28
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 21, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Feb 21, 2025
@sayboras
Copy link
Member

/test

@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Feb 21, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 21, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 23, 2025
@youngnick youngnick added this pull request to the merge queue Feb 24, 2025
Merged via the queue into cilium:main with commit d18aebc Feb 24, 2025
73 checks passed
@youngnick youngnick deleted the update-tls-cli branch February 24, 2025 02:55
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asauber asauber asauber approved these changes

@sayboras sayboras sayboras approved these changes

@Artyop Artyop Artyop approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youngnick @sayboras @asauber @Artyop