cli: Attribute test failures outside of action failures #37757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julian reports that when a test fails directly (via 't.Fail()', 't.Fatal()' and friends), the CLI falls back to attributing the failure to the ci-structure group that owns the overall testing infrastructure in the CLI, rather than attributing to the failed test itself. This commit amends the fallback when a failure is not triggered directly through an action / scenario by instead assembling all of the failed scenarios and then reporting the ownership for those failed scenarios. This should improve the accuracy of the test ownership attribution. Reported-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Joe Stringer <joe@cilium.io>
|
/test |
viktor-kurchenko
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julian reports that when a test fails directly (via
t.Fail(),t.Fatal()and friends), the CLI falls back to attributing the failureto the ci-structure group that owns the overall testing infrastructure
in the CLI, rather than attributing to the failed test itself.
This commit amends the fallback when a failure is not triggered directly
through an action / scenario by instead assembling all of the failed
scenarios and then reporting the ownership for those failed scenarios.
This should improve the accuracy of the test ownership attribution.