cli:connectivity: fix egress dev on aws-cni for pod-to-pod-encryption-v2 #37680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a52b938 to
df8e04b
Compare
|
/test |
|
Had to introduce one commit to enable Since we observed a different egress device being selected in our tests when That said, this commit is just for test purpose and won't be merged. |
ldelossa
approved these changes
Feb 17, 2025
|
/test |
33fd562 to
5d6780e
Compare
|
/test |
5d6780e to
da63240
Compare
|
/ci-awscni
Both 🟢, but looking at the debug messages it has always been selected |
|
/ci-awscni Same in these runs. |
|
/ci-awscni Hurray! Dropping the last commit then, re-running CI and marking ready-for-review. |
b12bb9f to
9f58f85
Compare
|
/test |
|
latest |
pchaigno
reviewed
Feb 19, 2025
|
Both actions are 🟢
Removing the 3rd commit and going through the process again. |
32a5ef5 to
c76cfda
Compare
c76cfda to
0bc9c5d
Compare
This commit adjusts the current logic in `pod-to-pod-encryption-v2` for
retrieving the egress device from client-server pods and vice-versa.
Before the patch, we solely rely on `ip route get dstIP`, using the
returned device as egress. However, we noticed that in aws-cni chaining
mode, such returned device is not actually used. Instead, looking at the
routing tables in the server node, we found that there's a specific table
with a route that uses a different egress device for that particular IP.
Therefore, the final command to be issued should be:
`ip route get {dstIP} from {srcIP} iif cilium_host`.
The interface specified does not matter since, if present, the route
matching srcIP is not making use of the interface field to match.
The related issue in our previous tests is #37675.
We now fix this for pod-to-pod-encryption-v2, but we might want to adopt
the same logic for v1.
Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
This commit moves our current parsing logic in pod-to-pod-encryption-v2 from strings to json decode in go structures. This makes our impl a bit more clear. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
0bc9c5d to
8eb0891
Compare
|
/test |
This was referenced Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes (only for v2): #37675
Fixes: #37682