Skip to content

Conversation

joestringer
Copy link
Member

When a test fails within an action, the action itself should be used to
report the failure to ensure that the failure is properly attributed in
the test framework.

When a test fails within an action, the action itself should be used to
report the failure to ensure that the failure is properly attributed in
the test framework.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Feb 14, 2025
@joestringer joestringer requested a review from a team as a code owner February 14, 2025 23:38
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Feb 14, 2025
@joestringer
Copy link
Member Author

/test

Copy link
Member

@ysksuzuki ysksuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joestringer joestringer added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit 1be9fac Feb 17, 2025
214 of 217 checks passed
@joestringer joestringer deleted the pr/joe/fix-egw-action-failures branch February 17, 2025 20:43
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants