-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add explicit IPv6 testing to PodToService cilium-cli connectivity test #37544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit IPv6 testing to PodToService cilium-cli connectivity test #37544
Conversation
e18257d
to
992cc98
Compare
/test |
992cc98
to
d0f263b
Compare
/test |
d0f263b
to
5172551
Compare
I checked the CI results from yesterday and found some tests related to PodToService failing. When I re-checked locally, all look good. So, rebased and pushed. @gentoo-root Can you re-trigger the CI again if you have time? |
/test |
@gentoo-root Sorry to mention you. But, any ideas on failing tests? I tested thoroughly in local and all look good, but in CI they fail. |
None so far, I'd have to investigate. PodToWorld tests fail in the CI due to lack of IPv6 connectivity to the external world in GitHub Actions, and I'm trying to work around it, but in your case the reason must be something else. |
I think that according to this error, we need to modify the cilium install defaults in workflow files to include ipv6. https://github.com/cilium/cilium/actions/runs/13328191435/workflow#L138-L156 In the above error, there is no IP for IPv6, resulting in http://:8080. What do you think? |
5172551
to
d0f8eba
Compare
Note that some workflows (e.g. GKE) cannot support IPv6 for technical reasons - thus we cannot simply change the install defaults to force IPv6, it just wouldn't work on setups like GKE. Thus test code must always dynamically query if IPv6 (or IPv4 for that matter) is actually enabled by Cilium. |
Thank you for clarification. |
Signed-off-by: saiaunghlyanhtet <saiaunghlyanhtet2003@gmail.com>
d0f8eba
to
b9b63fd
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
Conformance Clustermesh, one of the few dual-stack enabled workflows, was green on the first try: https://github.com/cilium/cilium/actions/runs/13534875974 Some of the upgrade tests failed, but that was because of a broken v1.17 CI image, unrelated to this branch. I've restarted the affected workflows. |
Add explicit IPv6 testing to PodToService cilium-cli connectivity test
Fixes: #37136