Skip to content

Add explicit IPv6 testing to PodToService cilium-cli connectivity test #37544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

saiaunghlyanhtet
Copy link
Member

Add explicit IPv6 testing to PodToService cilium-cli connectivity test

Fixes: #37136

@saiaunghlyanhtet saiaunghlyanhtet requested a review from a team as a code owner February 11, 2025 03:08
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 11, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Feb 11, 2025
@saiaunghlyanhtet saiaunghlyanhtet force-pushed the cilium-cli/pod-to-service-ipv6 branch from e18257d to 992cc98 Compare February 11, 2025 03:13
@julianwiedmann julianwiedmann added feature/ipv6 Relates to IPv6 protocol support release-note/ci This PR makes changes to the CI. labels Feb 11, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 11, 2025
@julianwiedmann julianwiedmann added the area/loadbalancing Impacts load-balancing and Kubernetes service implementations label Feb 11, 2025
@julianwiedmann
Copy link
Member

/test

@gentoo-root
Copy link
Contributor

/test

@saiaunghlyanhtet saiaunghlyanhtet force-pushed the cilium-cli/pod-to-service-ipv6 branch from d0f263b to 5172551 Compare February 13, 2025 12:35
@saiaunghlyanhtet
Copy link
Member Author

I checked the CI results from yesterday and found some tests related to PodToService failing. When I re-checked locally, all look good. So, rebased and pushed. @gentoo-root Can you re-trigger the CI again if you have time?

@gentoo-root
Copy link
Contributor

/test

@saiaunghlyanhtet
Copy link
Member Author

@gentoo-root Sorry to mention you. But, any ideas on failing tests? I tested thoroughly in local and all look good, but in CI they fail.

@gentoo-root
Copy link
Contributor

But, any ideas on failing tests?

None so far, I'd have to investigate. PodToWorld tests fail in the CI due to lack of IPv6 connectivity to the external world in GitHub Actions, and I'm trying to work around it, but in your case the reason must be something else.

@saiaunghlyanhtet
Copy link
Member Author

None so far, I'd have to investigate. PodToWorld tests fail in the CI due to lack of IPv6 connectivity to the external world in GitHub Actions, and I'm trying to work around it, but in your case the reason must be something else.

I think that according to this error, we need to modify the cilium install defaults in workflow files to include ipv6. https://github.com/cilium/cilium/actions/runs/13328191435/workflow#L138-L156

In the above error, there is no IP for IPv6, resulting in http://:8080.

What do you think?

@saiaunghlyanhtet saiaunghlyanhtet force-pushed the cilium-cli/pod-to-service-ipv6 branch from 5172551 to d0f8eba Compare February 25, 2025 13:36
@gandro
Copy link
Member

gandro commented Feb 25, 2025

I think that according to this error, we need to modify the cilium install defaults in workflow files to include ipv6. https://github.com/cilium/cilium/actions/runs/13328191435/workflow#L138-L156

Note that some workflows (e.g. GKE) cannot support IPv6 for technical reasons - thus we cannot simply change the install defaults to force IPv6, it just wouldn't work on setups like GKE.

Thus test code must always dynamically query if IPv6 (or IPv4 for that matter) is actually enabled by Cilium.

@saiaunghlyanhtet
Copy link
Member Author

I think that according to this error, we need to modify the cilium install defaults in workflow files to include ipv6. https://github.com/cilium/cilium/actions/runs/13328191435/workflow#L138-L156

Note that some workflows (e.g. GKE) cannot support IPv6 for technical reasons - thus we cannot simply change the install defaults to force IPv6, it just wouldn't work on setups like GKE.

Thus test code must always dynamically query if IPv6 (or IPv4 for that matter) is actually enabled by Cilium.

Thank you for clarification.

Signed-off-by: saiaunghlyanhtet <saiaunghlyanhtet2003@gmail.com>
@saiaunghlyanhtet saiaunghlyanhtet force-pushed the cilium-cli/pod-to-service-ipv6 branch from d0f8eba to b9b63fd Compare February 26, 2025 01:29
@saiaunghlyanhtet
Copy link
Member Author

/test

Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@gandro
Copy link
Member

gandro commented Feb 26, 2025

Conformance Clustermesh, one of the few dual-stack enabled workflows, was green on the first try: https://github.com/cilium/cilium/actions/runs/13534875974

Some of the upgrade tests failed, but that was because of a broken v1.17 CI image, unrelated to this branch. I've restarted the affected workflows.

@julianwiedmann julianwiedmann added this pull request to the merge queue Feb 26, 2025
Merged via the queue into cilium:main with commit d572ad0 Feb 26, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/loadbalancing Impacts load-balancing and Kubernetes service implementations cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary feature/ipv6 Relates to IPv6 protocol support release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add explicit IPv6 testing to PodToService cilium-cli connectivity test scenario
4 participants