Skip to content

Conversation

ti-mo
Copy link
Contributor

@ti-mo ti-mo commented Feb 6, 2025

Fixes: #34706

This PR removes all macros used for referring to maps that have been copy-pasta'd for an eternity. This is a requirement for getting to clang-free. The macros have been redundant since switching to ebpf-go for loading the datapath and were only needed for the few per-endpoint maps with dynamic names to begin with, yet here we are.

There are a few other benefits to doing this:

  • The bpf code more accurately reflects the names of the map pins on bpffs, making them more recognizable
  • No more stuff in node_config.h, making headers self-contained (eventually)
  • Much easier navigation due to less indirection
  • Significant code redution in WriteNodeConfig(), which will need to be ported as a whole to the new runtime datapath config framework

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 6, 2025
@ti-mo ti-mo added the release-note/misc This PR makes changes that have no direct user impact. label Feb 6, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 6, 2025
@ti-mo
Copy link
Contributor Author

ti-mo commented Feb 6, 2025

/test

@ti-mo ti-mo force-pushed the tb/userspace-dynamic-map-names branch from fc7d4e9 to 7ae6652 Compare February 20, 2025 16:16
@ti-mo
Copy link
Contributor Author

ti-mo commented Feb 20, 2025

/test

@ti-mo ti-mo force-pushed the tb/userspace-dynamic-map-names branch from 7ae6652 to 515bb7c Compare February 20, 2025 16:37
@ti-mo
Copy link
Contributor Author

ti-mo commented Feb 20, 2025

/test

@ti-mo ti-mo force-pushed the tb/userspace-dynamic-map-names branch from 515bb7c to 4ac4783 Compare February 24, 2025 15:26
@ti-mo
Copy link
Contributor Author

ti-mo commented Feb 24, 2025

/test

@ti-mo ti-mo force-pushed the tb/userspace-dynamic-map-names branch from 4ac4783 to 547ee89 Compare February 24, 2025 15:53
@ti-mo
Copy link
Contributor Author

ti-mo commented Feb 24, 2025

/test

@ti-mo ti-mo force-pushed the tb/userspace-dynamic-map-names branch from 547ee89 to 228c3db Compare February 25, 2025 08:48
@ti-mo
Copy link
Contributor Author

ti-mo commented Feb 25, 2025

/test

@ti-mo ti-mo force-pushed the tb/userspace-dynamic-map-names branch from 228c3db to 2e0a4ae Compare February 25, 2025 10:35
@ti-mo
Copy link
Contributor Author

ti-mo commented Feb 25, 2025

/test

1 similar comment
@ti-mo
Copy link
Contributor Author

ti-mo commented Feb 25, 2025

/test

@ti-mo ti-mo force-pushed the tb/userspace-dynamic-map-names branch from 2e0a4ae to 4f095e0 Compare February 26, 2025 16:36
@ti-mo
Copy link
Contributor Author

ti-mo commented Feb 26, 2025

/test

@ti-mo ti-mo marked this pull request as ready for review February 26, 2025 18:06
@ti-mo ti-mo requested review from a team as code owners February 26, 2025 18:06
@ti-mo ti-mo requested review from ysksuzuki, rgo3 and doniacld February 26, 2025 18:06
ti-mo added 20 commits March 12, 2025 21:24
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Also dropped __NR_CPUS__ from the map's maxentries, ebpf-go takes
care of setting this at load time.

Signed-off-by: Timo Beckers <timo@isovalent.com>
…acro

Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo force-pushed the tb/userspace-dynamic-map-names branch from 1877485 to 13dc40c Compare March 12, 2025 20:28
@ti-mo
Copy link
Contributor Author

ti-mo commented Mar 12, 2025

/test

@ti-mo ti-mo enabled auto-merge March 12, 2025 20:41
@ti-mo ti-mo added this pull request to the merge queue Mar 12, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 12, 2025
Merged via the queue into cilium:main with commit 1dc48ea Mar 13, 2025
66 of 67 checks passed
@ti-mo ti-mo deleted the tb/userspace-dynamic-map-names branch March 13, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dynamic map names in Cilium agent
6 participants