cilium-cli: Force curl to use IPv4/IPv6 when asked #37468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, CurlCommand() relies on peer.Address(ipFam) to be of the requested address family. However, it's not always the case, for example, httpEndpoint.Address() ignores its parameter and just returns the domain name. Make curl use the right address family in these cases by passing -4 or -6 accordingly. Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
|
/test |
borkmann
approved these changes
Feb 7, 2025
Currently the three repetitions are glued together in one line: fd00:10:244:1::6d49:52080 -> 2606:4700:4700::1001:80 = 503fd00:10:244:1::6d49:52068 -> 2606:4700:4700::1001:80 = 503fd00:10:244:1::6d49:52092 -> 2606:4700:4700::1001:80 = 503 After the change, it looks like: fd00:10:244:1::6d49:52080 -> 2606:4700:4700::1001:80 = 503 fd00:10:244:1::6d49:52068 -> 2606:4700:4700::1001:80 = 503 fd00:10:244:1::6d49:52092 -> 2606:4700:4700::1001:80 = 503 Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
|
/test |
Artyop
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CurlCommand() relies on peer.Address(ipFam) to be of the requested address family. However, it's not always the case, for example, httpEndpoint.Address() ignores its parameter and just returns the domain name.
Make curl use the right address family in these cases by passing -4 or -6 accordingly.
Dependency of #37435 and #37461