Skip to content

connectivity: Avoid hard-coded external target in warning log #37443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

connectivity: Avoid hard-coded external target in warning log #37443

merged 1 commit into from
Feb 5, 2025

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Feb 5, 2025

No description provided.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 5, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Feb 5, 2025
@sayboras
connectivity: Avoid hard-coded external target in warning log
53fe48a 
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/avoid-hardcoded-external-target branch from e7de36a to 53fe48a Compare February 5, 2025 09:52
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Feb 5, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 5, 2025
@sayboras
Copy link
Member Author

sayboras commented Feb 5, 2025

/test

@sayboras
Copy link
Member Author

sayboras commented Feb 5, 2025

Documentation update CI failure should be fixed by #37444, this is non-required job, so I don't think rebase and re-run is required (unless there is another push to incorporate review comment).

@sayboras sayboras marked this pull request as ready for review February 5, 2025 11:41
@sayboras sayboras requested review from a team as code owners February 5, 2025 11:41
@pchaigno pchaigno removed the request for review from aditighag February 5, 2025 13:57
@pchaigno pchaigno enabled auto-merge February 5, 2025 13:57
@pchaigno pchaigno added this pull request to the merge queue Feb 5, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 5, 2025
Merged via the queue into main with commit 141868c Feb 5, 2025
228 of 230 checks passed
@pchaigno pchaigno deleted the pr/tammach/avoid-hardcoded-external-target branch February 5, 2025 14:08
@joestringer joestringer mentioned this pull request Feb 20, 2025
Closed
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@Artyop Artyop Artyop approved these changes

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sayboras @pchaigno @Artyop @thorn3r