CODEOWNERS: adjust ownership of the pkg/crypto subpackages #37204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
reviewed
Jan 23, 2025
|
/ci-eks |
b9a5b1e to
ed97321
Compare
mhofstetter
requested changes
Jan 23, 2025
The `pkg/crypto/certloader` was originally contributed by SIG Hubble and is still mostly used and maintained by the Hubble team today. However, the `pkg/crypto/certificatemanager` package was contributed by the SIG Envoy team and is mostly relevant to them. In order to pull in the right people for code reviews, adjust the ownership of both packages with better granularity. Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
ed97321 to
3323af2
Compare
mhofstetter
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pkg/crypto/certloaderwas originally contributed by SIG Hubble and is still mostly used and maintained by the Hubble team today. However, thepkg/crypto/certificatemanagerpackage was contributed by the SIG Envoy team and is mostly relevant to them.In order to pull in the right people for code reviews, adjust the ownership of both packages with better granularity.
See also #37076 (comment)