fix: ignore encrypt interface field #37184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci-eks |
|
/ci-eks |
|
/ci-eks |
2 similar comments
|
/ci-eks |
|
/ci-eks |
This commit ignores the field EncryptInterface when verifying if there's any mutation of option.Config after its initialization. With this commit, triggering reinitializeIPSec path causing mutation when using it without kube-proxy replacement on EKS clusters won't fail Cilium startup. This is a temporary fix, once bpf_network will be removed for IPsec, EncryptInterface won't be used anymore. Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
5445904 to
d83fb6e
Compare
|
/ci-eks |
1 similar comment
|
/ci-eks |
|
/ci-eks |
1 similar comment
|
/ci-eks |
|
/test |
joamaki
approved these changes
Jan 23, 2025
aanm
approved these changes
Jan 23, 2025
|
It happens for 1.17, so adding the needs-backport/1.17 https://github.com/cilium/cilium/actions/runs/13810557501/job/38631004469 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ignores the field EncryptInterface when verifying if there's any mutation of option.Config after its initialization.
With this commit, triggering reinitializeIPSec path causing mutation when using it without kube-proxy replacement on EKS clusters won't fail Cilium startup.
This is a temporary fix, once bpf_network will be removed for IPsec, EncryptInterface won't be used anymore.
Fixes: #34794