Skip to content

cilium-cli: collect logs from crashing Cilium Agent pods #37013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Jan 16, 2025

In case some of the agents in the cluster are crashing, are in not
ready state or with container restarts, let's collect their logs as well.
This works even if node filter doesn't select nodes running such agents.

cilium-cli: collect Cilium Agent logs from crashing / not ready / restarted pods

@marseel marseel added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Jan 16, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 16, 2025
@marseel marseel added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jan 16, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 16, 2025
@marseel marseel force-pushed the pr/marseel/collect_failing_pods branch from ca5e5cc to e8af2f9 Compare January 16, 2025 11:37
@marseel
Copy link
Contributor Author

marseel commented Jan 16, 2025

/test

@marseel marseel marked this pull request as ready for review January 16, 2025 13:38
@marseel marseel requested a review from a team as a code owner January 16, 2025 13:38
@marseel marseel requested a review from derailed January 16, 2025 13:38
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marseel Nice work Marcel!

@marseel marseel force-pushed the pr/marseel/collect_failing_pods branch from e8af2f9 to 188233e Compare January 17, 2025 12:49
@marseel marseel requested a review from derailed January 17, 2025 13:07
@marseel
Copy link
Contributor Author

marseel commented Jan 17, 2025

/test

In case some of the agents in the cluster are crashing, are in not
ready state or with container restarts, let's collect their logs as well.
This works even if node filter doesn't select nodes running such agents.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the pr/marseel/collect_failing_pods branch from 188233e to f614783 Compare January 17, 2025 13:45
@marseel
Copy link
Contributor Author

marseel commented Jan 17, 2025

/test

Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marseel Thank you for the update and clarification.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 20, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue Jan 21, 2025
Merged via the queue into cilium:main with commit ab1ceb2 Jan 21, 2025
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants