-
Notifications
You must be signed in to change notification settings - Fork 3.4k
cilium-cli: collect logs from crashing Cilium Agent pods #37013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
julianwiedmann
merged 1 commit into
cilium:main
from
marseel:pr/marseel/collect_failing_pods
Jan 21, 2025
Merged
cilium-cli: collect logs from crashing Cilium Agent pods #37013
julianwiedmann
merged 1 commit into
cilium:main
from
marseel:pr/marseel/collect_failing_pods
Jan 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca5e5cc
to
e8af2f9
Compare
/test |
derailed
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marseel Nice work Marcel!
e8af2f9
to
188233e
Compare
/test |
In case some of the agents in the cluster are crashing, are in not ready state or with container restarts, let's collect their logs as well. This works even if node filter doesn't select nodes running such agents. Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
188233e
to
f614783
Compare
/test |
derailed
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marseel Thank you for the update and clarification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cilium-cli
This PR contains changes related with cilium-cli
cilium-cli-exclusive
This PR only impacts cilium-cli binary
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case some of the agents in the cluster are crashing, are in not
ready state or with container restarts, let's collect their logs as well.
This works even if node filter doesn't select nodes running such agents.