Skip to content

cli: restrict conn test to ip families #37000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

cli: restrict conn test to ip families #37000

merged 1 commit into from
Jan 17, 2025

Conversation

viktor-kurchenko
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko commented Jan 15, 2025 •
edited
Loading

The PR introduces a new input param for connectivity tests to restrict test actions to specific IP families.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 15, 2025
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Jan 15, 2025
@viktor-kurchenko viktor-kurchenko force-pushed the vk/pr/cli/conn/test/ipfams branch from 5e52dcf to 92d40de Compare January 16, 2025 15:08
@viktor-kurchenko viktor-kurchenko added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jan 16, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 16, 2025
@viktor-kurchenko viktor-kurchenko marked this pull request as ready for review January 16, 2025 15:10
@viktor-kurchenko viktor-kurchenko requested review from a team as code owners January 16, 2025 15:10
@viktor-kurchenko
Copy link
Contributor Author

/test

Artyop
Artyop approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Artyop Artyop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

derailed
derailed approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viktor-kurchenko LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 17, 2025
@viktor-kurchenko
cli: restrict conn test to ip families
8d4ca68 
The commit introduces a new input param for connectivity tests to
restrict test actions to specific IP families.

Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
@viktor-kurchenko viktor-kurchenko force-pushed the vk/pr/cli/conn/test/ipfams branch from 92d40de to 8d4ca68 Compare January 17, 2025 15:01
@viktor-kurchenko
Copy link
Contributor Author

/test

@joestringer joestringer added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 98b4655 Jan 17, 2025
216 checks passed
@joestringer joestringer deleted the vk/pr/cli/conn/test/ipfams branch January 17, 2025 21:52
@github-actions github-actions bot mentioned this pull request Feb 3, 2025
Open
@squeed squeed mentioned this pull request Aug 21, 2025
Closed
@kglushen kglushen mentioned this pull request Aug 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

@Artyop Artyop Artyop approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viktor-kurchenko @derailed @Artyop @joestringer