Skip to content

Conversation

MrFreezeex
Copy link
Member

This commit updates the mcs-api deps addressing two issues:

  • An headless ServiceImport should have an empty IPs list and not a list containing the string "None"
  • Add support for dual stack services by copying at most two ips from the derived Service instead of only one (requires a CRD change, hence also updating the install documentation).
clustermesh: add dualstack support for MCS-API and fix a spec compliance issue with headless services

This commit updates the mcs-api deps addressing two issues:
- An headless ServiceImport should have an empty IPs list and not a list
  containing the string "None"
- Add support for dual stack services by copying at most two ips from
  the derived Service instead of only one (requires a CRD change, hence
  also updating the install documentation).

Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
@MrFreezeex MrFreezeex requested review from a team as code owners January 17, 2025 14:29
@MrFreezeex MrFreezeex requested review from marseel and qmonnet January 17, 2025 14:29
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 17, 2025
@MrFreezeex
Copy link
Member Author

/test

Copy link
Contributor

@marseel marseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qmonnet qmonnet added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/clustermesh Relates to multi-cluster routing functionality in Cilium. labels Jan 20, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 20, 2025
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc change looks good, thank you!

@giorio94 giorio94 added the needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch label Jan 20, 2025
@giorio94
Copy link
Member

Marked for backport to v1.17, so that we directly ship the updated version there as well.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 20, 2025
@qmonnet qmonnet added this pull request to the merge queue Jan 20, 2025
Merged via the queue into cilium:main with commit 35b54e7 Jan 20, 2025
76 checks passed
@rastislavs rastislavs mentioned this pull request Jan 21, 2025
45 tasks
@rastislavs rastislavs added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 21, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants