doc: Removed nodeinit from aks byocni install #37048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodeinit is actually not required when running Cilium on AKS BYOCNI. Hence, let's remove it from the AKS BYOCNI-specific Helm installation guide. Signed-off-by: Philip Schmid <phisch@cisco.com>
wedaly
approved these changes
Jan 17, 2025
|
incidentally, even the Azure CNI bridge -> transparent mode hacks I removed in #34870 aren't necessary for BYO CNI, since BYO CNI doesn't install Azure CNI. |
|
/test |
joestringer
approved these changes
Jan 18, 2025
45 tasks
19 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodeinit is actually not required when running Cilium on AKS BYOCNI. Hence, let's remove it from the AKS BYOCNI-specific Helm installation guide.
Nodeinit’s startup.bash or prestop.bash don't to anything specific to AKS BYOCNI (1.15.6 versions). Everything seems to be GKE-specific except one section in the startup.bash, which is for Azure chaining mode (
.Values.azure.enabled) and even that part is removed in later Cilium versions (see #34870).It needs a backport to all maintained Cilium minor versions.