docs: Clarify Identity-Relevant Labels description #36924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The labels configuration for the agent is quite important to how Cilium respects the labels of workloads in order to properly enforce network policy. Through recent review a few ambiguities were pointed out to me, so this commit attempts to clarify those points. Thanks to Filip Nikolic and André Martins for the detailed discussion that motivated this wording change. Signed-off-by: Joe Stringer <joe@cilium.io>
tklauser
approved these changes
Jan 10, 2025
jibi
approved these changes
Jan 10, 2025
qmonnet
approved these changes
Jan 10, 2025
|
/test |
aanm
approved these changes
Jan 10, 2025
45 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The labels configuration for the agent is quite important to how Cilium
respects the labels of workloads in order to properly enforce network
policy. Through recent review a few ambiguities were pointed out to me,
so this commit attempts to clarify those points.
Thanks to @f1ko and @aanm for the detailed discussion that motivated
this wording change.