Skip to content

Conversation

PhilipSchmid
Copy link
Contributor

Documented the known limitation of Cilium's eBPF host routing when relying on netfilter hooks at the same time.

cc @giorio94, @marseel

doc: ebpf host-routing and netfilter

@PhilipSchmid PhilipSchmid requested review from a team as code owners January 9, 2025 15:44
@PhilipSchmid PhilipSchmid requested review from YutaroHayakawa and a user January 9, 2025 15:44
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 9, 2025
@ghost ghost added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jan 9, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 9, 2025
@ghost
Copy link

ghost commented Jan 9, 2025

/test

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor wording suggestion.

@ghost
Copy link

ghost commented Jan 9, 2025

@PhilipSchmid Does this limitation apply to Cilium v1.17 or older versions? (i.e.: should the change be backported?)

Documented the known limitation of Cilium's eBPF host routing
when relying on netfilter hooks at the same time.

Signed-off-by: Philip Schmid <phisch@cisco.com>
@PhilipSchmid PhilipSchmid force-pushed the pr/philip/doc_netfilter_limitation_for_bpf_hostrouting branch from ad4a480 to 67ec5a4 Compare January 9, 2025 16:23
@PhilipSchmid
Copy link
Contributor Author

@lambdanis It also applies to 1.16. So yeah, please add the backport label.

@ghost ghost added needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 9, 2025
@joestringer joestringer closed this Jan 9, 2025
@joestringer joestringer reopened this Jan 9, 2025
@joestringer
Copy link
Member

/test

@joestringer joestringer enabled auto-merge January 9, 2025 21:05
@joestringer joestringer added this pull request to the merge queue Jan 9, 2025
Merged via the queue into cilium:main with commit dc5037b Jan 9, 2025
92 of 101 checks passed
@julianwiedmann julianwiedmann added the area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Jan 10, 2025
@rastislavs rastislavs mentioned this pull request Jan 21, 2025
45 tasks
@rastislavs rastislavs added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 21, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Jan 22, 2025
@rastislavs rastislavs mentioned this pull request Jan 22, 2025
19 tasks
@rastislavs rastislavs added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Jan 22, 2025
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Jan 24, 2025
@PhilipSchmid PhilipSchmid deleted the pr/philip/doc_netfilter_limitation_for_bpf_hostrouting branch June 26, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants