Skip to content

Conversation

aanm
Copy link
Member

@aanm aanm commented Jan 9, 2025

When the images are built from stable branches we should also publish floating images from those branches.

Fixes: 5ce3112 (".github: simplify build-images-ci workflow")

When the images are built from stable branches we should also publish
floating images from those branches.

Fixes: 5ce3112 (".github: simplify build-images-ci workflow")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 9, 2025
@aanm aanm requested review from a team as code owners January 9, 2025 12:20
@aanm aanm requested a review from brlbil January 9, 2025 12:20
@aanm aanm enabled auto-merge January 9, 2025 12:25
@aanm
Copy link
Member Author

aanm commented Jan 9, 2025

/test

Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, just a note that this workflow is with pull_request_target, so might need to verify once it's merged.

@aanm aanm added this pull request to the merge queue Jan 9, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 9, 2025
Merged via the queue into main with commit 4638384 Jan 9, 2025
72 checks passed
@aanm aanm deleted the pr/fix-image-ci branch January 9, 2025 12:56
@rastislavs rastislavs mentioned this pull request Jan 21, 2025
45 tasks
@rastislavs rastislavs added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 21, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants