make: Don't hide install errors #36980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The make "kind-install-cilium-fast" target was previously hiding all errors and running installs in the background. As soon as any sort of error is introduced into the install process, this means that developers attempting to make those changes will get weird failing behavior without any sort of feedback about why this part of the process is working. Ensure that stderr is printed to the shell and avoid running multiple clustermeshes in parallel. Signed-off-by: Joe Stringer <joe@cilium.io>
borkmann
approved these changes
Jan 17, 2025
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The make "kind-install-cilium-fast" target was previously hiding all
errors and running installs in the background. As soon as any sort of
error is introduced into the install process, this means that developers
attempting to make those changes will get weird failing behavior without
any sort of feedback about why this part of the process is working.
Ensure that stderr is printed to the shell and avoid running multiple
clustermeshes in parallel.