Skip to content

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Dec 30, 2024

This test is same as the existing seq-client-egress-l7-tls-headers test,
but the secret is updated with one additional host (e.g. cilium.io), so
that we can verify the update path is still working as expected.

Signed-off-by: Tam Mach tam.mach@cilium.io

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 30, 2024
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Dec 30, 2024
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Dec 30, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 30, 2024
@sayboras sayboras force-pushed the pr/tammach/rotate-cert branch 3 times, most recently from 1b8e3ce to d957ddc Compare December 30, 2024 12:08
@sayboras
Copy link
Member Author

/test

@sayboras sayboras force-pushed the pr/tammach/rotate-cert branch from d957ddc to 8da43d6 Compare January 9, 2025 04:20
@sayboras sayboras changed the title connectivity: Add test for rotated TLS secret connectivity: Add test for update TLS secret Jan 9, 2025
@sayboras sayboras force-pushed the pr/tammach/rotate-cert branch 4 times, most recently from 23baa2f to e144bd0 Compare January 9, 2025 10:13
This test is same as the existing seq-client-egress-l7-tls-headers test,
but the secret is updated with one additional host (e.g. cilium.io), so
that we can verify the update path is still working as expected.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/rotate-cert branch from e144bd0 to f23a0e1 Compare January 9, 2025 10:13
@sayboras sayboras marked this pull request as ready for review January 9, 2025 10:14
@sayboras sayboras requested review from a team as code owners January 9, 2025 10:14
@sayboras sayboras requested review from mhofstetter and Artyop January 9, 2025 10:14
@sayboras sayboras marked this pull request as draft January 9, 2025 10:14
@sayboras sayboras marked this pull request as ready for review January 9, 2025 10:23
@mhofstetter
Copy link
Member

/test

@sayboras sayboras enabled auto-merge January 10, 2025 08:13
Copy link
Contributor

@Artyop Artyop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sayboras sayboras added this pull request to the merge queue Jan 10, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 10, 2025
Merged via the queue into main with commit f9d1fec Jan 10, 2025
224 checks passed
@sayboras sayboras deleted the pr/tammach/rotate-cert branch January 10, 2025 10:08
@sayboras sayboras added needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 15, 2025
sayboras added a commit that referenced this pull request Feb 3, 2025
Similar to what was done in #36812, but for another TLS inspection
related test case.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras added a commit that referenced this pull request Feb 3, 2025
Similar to what was done in #36812, but for another TLS inspection
related test case.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2025
Similar to what was done in #36812, but for another TLS inspection
related test case.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
acelinkio pushed a commit to acelinkio/cilium that referenced this pull request Feb 5, 2025
Similar to what was done in cilium#36812, but for another TLS inspection
related test case.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
jongj pushed a commit to jongj/cilium that referenced this pull request Feb 11, 2025
Similar to what was done in cilium#36812, but for another TLS inspection
related test case.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
karina-ranadive pushed a commit to karina-ranadive/cilium that referenced this pull request Jun 24, 2025
Similar to what was done in cilium#36812, but for another TLS inspection
related test case.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants