Skip to content

Conversation

MrFreezeex
Copy link
Member

@MrFreezeex MrFreezeex commented Jan 8, 2025

This fixes a bug where we where not properly deleting the service export cache on a delete event from remote cluster which for instance prevents ServiceImport to be properly deleted in some/most cases.

clustermesh:  fix MCS-API service export cache not properly deleted

Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 8, 2025
@MrFreezeex
Copy link
Member Author

MrFreezeex commented Jan 8, 2025

FYI I spotted this with the MCS-API conformance test: "Exporting a ClusterIP service should create a ServiceImport of type ClusterSetIP in the service's namespace in each cluster. Unexporting should delete the ServiceImport".

I was already running the conformance test (https://github.com/kubernetes-sigs/mcs-api/tree/master/conformance) regularly but it turns out I was not running it correctly in the past and I was effectively running it on only one of my cluster instead of two... which does test a few things but as you might expect leave a few things untested...

I will also start looking relatively soon at integrating this conformance test in the CI, the only thing is that we currently don't pass an (optional) test that checks for EndpointSlice because we only sync EndpointSlice if the user opted in with an annotation or if the service is headless and the conformance tests doesn't know about this Cilium specific details. But will try to figure out the best path forward to integrate this conformance test which would help us getting a "free" e2etest suite and catch a few more bugs like this one!

@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex marked this pull request as ready for review January 8, 2025 18:14
@MrFreezeex MrFreezeex requested a review from a team as a code owner January 8, 2025 18:14
@MrFreezeex MrFreezeex requested a review from giorio94 January 8, 2025 18:14
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@giorio94 giorio94 added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. area/clustermesh Relates to multi-cluster routing functionality in Cilium. needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 10, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 10, 2025
@giorio94
Copy link
Member

I will also start looking relatively soon at integrating this conformance test in the CI, the only thing is that we currently don't pass an (optional) test that checks for EndpointSlice because we only sync EndpointSlice if the user opted in with an annotation or if the service is headless and the conformance tests doesn't know about this Cilium specific details. But will try to figure out the best path forward to integrate this conformance test which would help us getting a "free" e2etest suite and catch a few more bugs like this one!

That would be great, thanks! Feel free to ask if you need help with the CI. As for the currently failing test, I guess that one possibility in the short term could be just skipping it, so that we still get all the others for free.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 10, 2025
@julianwiedmann julianwiedmann added this pull request to the merge queue Jan 10, 2025
Merged via the queue into cilium:main with commit e53c222 Jan 10, 2025
70 checks passed
@rastislavs rastislavs mentioned this pull request Jan 21, 2025
45 tasks
@rastislavs rastislavs added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 21, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants