Cilium CLI fix for AWS ENI mode #36887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use both `eth+` and `ens+` interfaces only with newer CLI versions due to a bug in iptables provisioning for the older Cilium versions. Signed-off-by: viktor-kurchenko <viktor.kurchenko@isovalent.com>
aanm
approved these changes
Jan 8, 2025
|
/test |
michi-covalent
approved these changes
Jan 8, 2025
asauber
approved these changes
Jan 8, 2025
michi-covalent
added a commit
that referenced
this pull request
Jan 28, 2025
Ref: #36887 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jan 28, 2025
Ref: #36887 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jan 28, 2025
The egressMasqueradeInterfaces Helm value incorrectly gets set to "eth+" instead of "eth+ ens+" because of the version check ">=1.17.0" added in #36887. versioncheck.Version does not ignore alpha/beta/rc/snapshot pre-release versions [^1]. Explicitly set egressMasqueradeInterfaces to 'eth+ ens+' as a workaround. [^1]: https://github.com/cilium/cilium/blob/2a349d5c5353cf0235414579885122425025dbdb/pkg/versioncheck/check.go#L44-L71 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
The egressMasqueradeInterfaces Helm value incorrectly gets set to "eth+" instead of "eth+ ens+" because of the version check ">=1.17.0" added in #36887. versioncheck.Version does not ignore alpha/beta/rc/snapshot pre-release versions [^1]. Explicitly set egressMasqueradeInterfaces to 'eth+ ens+' as a workaround. [^1]: https://github.com/cilium/cilium/blob/2a349d5c5353cf0235414579885122425025dbdb/pkg/versioncheck/check.go#L44-L71 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
joestringer
pushed a commit
that referenced
this pull request
Jan 29, 2025
The egressMasqueradeInterfaces Helm value incorrectly gets set to "eth+" instead of "eth+ ens+" because of the version check ">=1.17.0" added in #36887. versioncheck.Version does not ignore alpha/beta/rc/snapshot pre-release versions [^1]. Explicitly set egressMasqueradeInterfaces to 'eth+ ens+' as a workaround. [^1]: https://github.com/cilium/cilium/blob/2a349d5c5353cf0235414579885122425025dbdb/pkg/versioncheck/check.go#L44-L71 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
jrajahalme
pushed a commit
that referenced
this pull request
Jul 10, 2025
[ upstream commit 72369a6 ] The egressMasqueradeInterfaces Helm value incorrectly gets set to "eth+" instead of "eth+ ens+" because of the version check ">=1.17.0" added in #36887. versioncheck.Version does not ignore alpha/beta/rc/snapshot pre-release versions [^1]. Explicitly set egressMasqueradeInterfaces to 'eth+ ens+' as a workaround. [^1]: https://github.com/cilium/cilium/blob/2a349d5c5353cf0235414579885122425025dbdb/pkg/versioncheck/check.go#L44-L71 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
jrajahalme
pushed a commit
that referenced
this pull request
Jul 12, 2025
[ upstream commit 72369a6 ] The egressMasqueradeInterfaces Helm value incorrectly gets set to "eth+" instead of "eth+ ens+" because of the version check ">=1.17.0" added in #36887. versioncheck.Version does not ignore alpha/beta/rc/snapshot pre-release versions [^1]. Explicitly set egressMasqueradeInterfaces to 'eth+ ens+' as a workaround. [^1]: https://github.com/cilium/cilium/blob/2a349d5c5353cf0235414579885122425025dbdb/pkg/versioncheck/check.go#L44-L71 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
[ upstream commit 72369a6 ] The egressMasqueradeInterfaces Helm value incorrectly gets set to "eth+" instead of "eth+ ens+" because of the version check ">=1.17.0" added in #36887. versioncheck.Version does not ignore alpha/beta/rc/snapshot pre-release versions [^1]. Explicitly set egressMasqueradeInterfaces to 'eth+ ens+' as a workaround. [^1]: https://github.com/cilium/cilium/blob/2a349d5c5353cf0235414579885122425025dbdb/pkg/versioncheck/check.go#L44-L71 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
[ upstream commit 72369a6 ] The egressMasqueradeInterfaces Helm value incorrectly gets set to "eth+" instead of "eth+ ens+" because of the version check ">=1.17.0" added in #36887. versioncheck.Version does not ignore alpha/beta/rc/snapshot pre-release versions [^1]. Explicitly set egressMasqueradeInterfaces to 'eth+ ens+' as a workaround. [^1]: https://github.com/cilium/cilium/blob/2a349d5c5353cf0235414579885122425025dbdb/pkg/versioncheck/check.go#L44-L71 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use both
eth+andens+interfaces only with newer CLI versions due to a bug in iptables provisioning for the older Cilium versions.