gha: correctly downgrade to patch release in ipsec workflows #36858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
439f558 ("CLI: cilium upgrade preserver previous configurations") changed the default behavior of `cilium upgrade` to preserve the previous configuration upon upgrade. While this is the expected behavior in most situations, it turned out being problematic in the ipsec upgrade downgrade tests (specifically in case of patch matrix entries). Indeed, the images are not overwritten for the stable configuration, leading in turn to not actually performing the downgrade. Let's fix this by explicitly resetting the values when performing the upgrade and downgrade operations. Reported-by: Jarno Rajahalme <jarno@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
|
/test |
pchaigno
approved these changes
Jan 7, 2025
45 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
439f558 ("CLI: cilium upgrade preserver previous configurations") changed the default behavior of
cilium upgradeto preserve the previous configuration upon upgrade. While this is the expected behavior in most situations, it turned out being problematic in the ipsec upgrade downgrade tests (specifically in case of patch matrix entries). Indeed, the images are not overwritten for the stable configuration, leading in turn to not actually performing the downgrade. Let's fix this by explicitly resetting the values when performing the upgrade and downgrade operations.Reported-by: Jarno Rajahalme jarno@isovalent.com