cilium: minor hostport fixes #36856
cilium: minor hostport fixes #36856
Conversation
If KPR is false, setting these to true does not make any sense. Thus, remove this to avoid confusion. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
hostPort.enabled=true under KPR off is not supported given the former relies on the latter's infrastructure. Remove this from the docs to avoid confusion. Before 1a4e7d4 ("docs: Adjust KPR GSG to --kpr=boolean changes") this sentence was meant in the context of KPR=partial. Fixes: 1a4e7d4 ("docs: Adjust KPR GSG to --kpr=boolean changes") Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
|
/test |
| @@ -745,12 +745,12 @@ data: | |||
| {{- end }} | |||
|
|
|||
| {{- if hasKey .Values "hostPort" }} | |||
| {{- if or (eq $kubeProxyReplacement "partial") (eq $kubeProxyReplacement "false") }} | |||
| {{- if eq $kubeProxyReplacement "partial" }} | |||
There was a problem hiding this comment.
So hostPort and externalIPs Helm values take effect only if kubeProxyReplacement is set to "partial", but partial kpr is deprecated for a while, right? Then it might make sense to mark these Helm values as deprecated too?
There was a problem hiding this comment.
Yes, that would make sense (and could be as separate PR) - more could be followed as well to simplify. Do you have some pointers how this is done in helm?
There was a problem hiding this comment.
I believe typically Helm values are just described as deprecated in the Helm doc comment, like here, plus upgrade notes. But I'm not sure if Helm templates should use "partial" kpr value if it's deprecated - I suppose it was kept for backwards compatibility, but maybe at this point it can be removed entirely?
There was a problem hiding this comment.
I removed the conditions - #39721, because "partial" is no longer available since v1.14 (EOL).
(see commit desc)