Add GOARCH to go install dlv command #36853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@borkmann I discovered this issue while working on tasks piggy-backing #31213. Could you please approve the image build? Once it is completed, I will add add a commit to update the image hash. |
aanm
approved these changes
Jan 14, 2025
If BUILDPLATFORM and TARGETPLATFORM are different, the dlv command will be copied for the wrong architecture. Because of debug cilium images are just copy the dlv command from the builder image. This change adds GOARCH to the go install command to ensure the dlv command is built for the correct architecture. Signed-off-by: Gyutae Bae <gyu.8ae@gmail.com>
kaworu
approved these changes
Jan 14, 2025
Signed-off-by: André Martins <andre@cilium.io>
|
/test |
Artyop
approved these changes
Jan 14, 2025
|
@Artyop @aanm @kaworu Thank you for the review. An error occurred in job 6 during the Cilium E2E Upgrade test. It seems to be a temporary issue as it failed to find the lvh images. Could you please trigger |
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
If
BUILDPLATFORMandTARGETPLATFORMare different, the dlv command will be copied for the wrong architecture. Because of debug cilium images are just copy the dlv command from the builder image. It causedexec format errorwhile running debug cilium image. This change adds GOARCH to the go install command to ensure the dlv command is built for the correct architecture.