Skip to content

envoy: Configure internal address config based on IP family #36733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

envoy: Configure internal address config based on IP family #36733

merged 1 commit into from
Jan 7, 2025

Conversation

sayboras
Copy link
Member

There is upstream issue which might cause IP malformed error, this
commit is to make sure that ::1/128 is added to internal address config
if IPv6 is enabled in Cilium.

Relates: envoyproxy/envoy#29902
Fixes: #35943
Fixes: #36691
Signed-off-by: Tam Mach tam.mach@cilium.io

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 19, 2024
@sayboras sayboras added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.14 needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Dec 19, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 19, 2024
@sayboras sayboras mentioned this pull request Dec 19, 2024
Closed
3 tasks
jrajahalme
jrajahalme reviewed Dec 20, 2024
View reviewed changes
@sayboras sayboras force-pushed the pr/tammach/envoy-ipv6-parse branch from 535f3c9 to 48f82df Compare December 20, 2024 23:07
@sayboras
Copy link
Member Author

/test

@sayboras sayboras force-pushed the pr/tammach/envoy-ipv6-parse branch 4 times, most recently from cd17b81 to 99c856e Compare December 23, 2024 08:50
@sayboras sayboras marked this pull request as ready for review December 23, 2024 12:59
@sayboras sayboras requested review from a team as code owners December 23, 2024 12:59
jrajahalme
jrajahalme requested changes Dec 26, 2024
View reviewed changes
@sayboras sayboras mentioned this pull request Jan 3, 2025
Merged
@sayboras sayboras force-pushed the pr/tammach/envoy-ipv6-parse branch from 99c856e to ea189cf Compare January 3, 2025 04:02
@sayboras sayboras requested a review from jrajahalme January 3, 2025 04:03
@sayboras
envoy: Configure internal address config based on IP family
82ba0c6 
There is upstream issue which might cause IP malformed error, this
commit is to make sure that ::1/128 is added to internal address config
if IPv6 is enabled in Cilium.

Relates: envoyproxy/envoy#29902
Fixes: #35943
Fixes: #36691
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/envoy-ipv6-parse branch from ea189cf to 82ba0c6 Compare January 6, 2025 07:57
@sayboras
Copy link
Member Author

sayboras commented Jan 6, 2025

/test

@jrajahalme jrajahalme added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit d9e64fc Jan 7, 2025
292 checks passed
@jrajahalme jrajahalme deleted the pr/tammach/envoy-ipv6-parse branch January 7, 2025 08:57
@sayboras sayboras added the backport/author The backport will be carried out by the author of the PR. label Jan 7, 2025
@sayboras sayboras mentioned this pull request Jan 7, 2025
Merged
6 tasks
@sayboras sayboras added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 7, 2025
@sayboras sayboras mentioned this pull request Jan 7, 2025
Merged
3 tasks
@sayboras sayboras added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Jan 7, 2025
@sayboras sayboras mentioned this pull request Jan 7, 2025
Merged
2 tasks
@sayboras sayboras added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 labels Jan 7, 2025
@sayboras sayboras mentioned this pull request Jan 8, 2025
Merged
2 tasks
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. labels Jan 8, 2025
@sayboras sayboras added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Jan 9, 2025
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 9, 2025
This was referenced Jan 10, 2025
Merged
Merged
Merged
Merged
@cilium-release-bot cilium-release-bot bot mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

Assignees
No one assigned
Labels
backport/author The backport will be carried out by the author of the PR. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cilium Envoy 1.16.5 crashes on systems with IPv6 disabled
3 participants
@sayboras @squeed @jrajahalme