Skip to content

ingress: Remove multiple network device limitation #36769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

ingress: Remove multiple network device limitation #36769

merged 1 commit into from
Jan 9, 2025

Conversation

sayboras
Copy link
Member

This limitation can be removed after #35143.

Relates: #35143
Relates: #24318

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 23, 2024
@sayboras sayboras added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Dec 23, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 23, 2024
@sayboras
ingress: Remove multiple network device limitation
2ff0589 
This limitation can be removed after #35143.

Relates: #35143
Relates: #24318
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/tammach/remove-ingress-known-issue branch from cc71163 to 2ff0589 Compare January 9, 2025 10:25
@sayboras sayboras marked this pull request as ready for review January 9, 2025 10:26
@sayboras sayboras requested review from a team as code owners January 9, 2025 10:26
@sayboras sayboras requested review from mhofstetter and a user January 9, 2025 10:26
@sayboras sayboras removed the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Jan 9, 2025
@mhofstetter mhofstetter requested review from jrajahalme and removed request for mhofstetter January 9, 2025 10:30
@mhofstetter
Copy link
Member

mhofstetter commented Jan 9, 2025 •
edited
Loading

@jrajahalme please double-check as you were involved with the changes

jrajahalme
jrajahalme approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this myself, trusting @sayboras to have tested this out.

@sayboras
Copy link
Member Author

sayboras commented Jan 9, 2025

Haven't tested this myself, trusting @sayboras to have tested this out.

yes, I have done the testing with the repro step from user #24318 (comment)

@sayboras
Copy link
Member Author

sayboras commented Jan 9, 2025

/test

@sayboras sayboras added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 900cb76 Jan 9, 2025
69 checks passed
@sayboras sayboras deleted the pr/tammach/remove-ingress-known-issue branch January 9, 2025 23:15
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 9, 2025
@rastislavs rastislavs mentioned this pull request Jan 21, 2025
Merged
45 tasks
@rastislavs rastislavs added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 21, 2025
@github-actions github-actions bot removed the backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. label Jan 22, 2025
@github-actions github-actions bot added the backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. label Jan 22, 2025
@cilium-release-bot cilium-release-bot bot mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrajahalme jrajahalme jrajahalme approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sayboras @mhofstetter @jrajahalme @rastislavs