-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[WIP]Support IPv6 for delegated IPAM #36656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Rui Cao <caorui.io@bytedance.com>
cc @rjdenney, need to add helm values when testing ipv6: enableIPv6Masquerade: false
extraArgs: ["--local-router-ipv4=169.254.23.0", "--local-router-ipv6=fe80::"]
ipv6:
enabled: true |
I'll make sure to add the correct helm values. Also I noticed that you added a change in your previous PR that made it so that the routes would only be created if |
@rjdenney |
I have been trying to test this but keep seeing this error in the logs when creating pods and have been having issues getting v6 IPs to be programmed to pods.
I have also been seeing this issue when trying to test on main. In the current verison of Cilium we are using for AKS I am able to create a dualstack cluster the does program the pods with IPv4 and IPv6. I can see that the delegated plugin is sending the expected IPv4 and IPv6 for pods as well as gateway IPs but can't seem to get the pods to program correctly. Also I believe aks should already be sending the correct helm values already but if there is somewhere new I need to update them in the Cilium repo itself before building it.
|
hi @rjdenney, could you upload the full agent and cni log? The log shows ipv6 address is empty: Here is the helm values from my test env FYI:
|
I updated the cm to match the helms you have, and I am now seeing the V6 IPs as well as the gateway IP getting routed. Thanks! |
@ruicao93 Is this ready to be reviewed or do you think something is missing? If the latter, I'd suggest moving it back to draft, for now. 🙏 |
Converting to draft given the PR title, description, and inactivity. Feel free to mark ready for review when you are ready. |
This pull request has been automatically marked as stale because it |
This pull request has not seen any activity since it was marked stale. |
TODOs: add ipv6 tests