Skip to content

cilium-cli: connectivity: clean up any leftover egw routes. #36651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2025
Merged

cilium-cli: connectivity: clean up any leftover egw routes. #36651

merged 1 commit into from
Apr 1, 2025

Conversation

tommyp1ckles
Copy link
Contributor

@tommyp1ckles tommyp1ckles commented Dec 17, 2024 •
edited
Loading

If the CLI crashes or is stopped before running cleanup hooks, the egw routes installed on some nodes will cause other tests to fail. To prevent this, automatically try to clean these up on startup to avoid any confusing issues from leftover routes.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 17, 2024
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Dec 17, 2024
@tommyp1ckles tommyp1ckles changed the title cilium-cli: connectivity: clean up any leftover egwha routes. cilium-cli: connectivity: clean up any leftover egw routes. Dec 17, 2024
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/conn-test-cleanup-egw-routes-on-startup branch from bfe062c to 28cdad6 Compare December 17, 2024 16:58
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/conn-test-cleanup-egw-routes-on-startup branch from 28cdad6 to db32017 Compare January 14, 2025 05:38
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles force-pushed the pr/tp/conn-test-cleanup-egw-routes-on-startup branch from db32017 to 7252c3e Compare January 31, 2025 02:29
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles added the release-note/ci This PR makes changes to the CI. label Jan 31, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 31, 2025
@tommyp1ckles tommyp1ckles marked this pull request as ready for review January 31, 2025 02:29
@tommyp1ckles tommyp1ckles requested a review from a team as a code owner January 31, 2025 02:29
@tommyp1ckles tommyp1ckles requested a review from Artyop January 31, 2025 02:29
@Artyop
Copy link
Contributor

Artyop commented Jan 31, 2025

/test

@Artyop Artyop requested review from a team and asauber and removed request for a team January 31, 2025 10:18
Artyop
Artyop approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@Artyop Artyop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, waiting for tests to comply and I've asked also someone from cli to check

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Mar 3, 2025
@Artyop Artyop removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Mar 3, 2025
@Artyop
Copy link
Contributor

Artyop commented Mar 3, 2025

@tommyp1ckles I don't have write access to merge this

@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles
cilium-cli: connectivity: clean up any leftover egw routes.
e2dc03b 
If the CLI crashes or is stopped before running cleanup hooks, the
egw routes installed on some nodes will cause other tests to fail.
To prevent this, automatically try to clean these up on startup to
avoid any confusing issues from leftover routes.

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles tommyp1ckles force-pushed the pr/tp/conn-test-cleanup-egw-routes-on-startup branch from 7252c3e to e2dc03b Compare March 28, 2025 00:58
@tommyp1ckles
Copy link
Contributor Author

/test

@tommyp1ckles tommyp1ckles enabled auto-merge March 28, 2025 00:58
@tommyp1ckles tommyp1ckles added this pull request to the merge queue Apr 1, 2025
Merged via the queue into cilium:main with commit 6c84fc8 Apr 1, 2025
67 checks passed
@tommyp1ckles tommyp1ckles deleted the pr/tp/conn-test-cleanup-egw-routes-on-startup branch April 1, 2025 05:41
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Apr 1, 2025
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asauber asauber asauber approved these changes

@Artyop Artyop Artyop approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommyp1ckles @Artyop @asauber