cilium-cli/connectivity: fix IPv6 feature check for 2ndary node IPv6 #36513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the feature check is for IPv4 to be enabled, even though the secondary node IPv6 address is configured. This was likely copy-pasted from the section above which does the corresponding configuration of the secondary node IPv4 address. Fix the feature check accordingly to check for IPv6 to be enabled. Fixes: #35125 Fixes: 8498092 ("connectivity: Add secondary network NodePort tests") Signed-off-by: Tobias Klauser <tobias@cilium.io>
a8a913a to
868903b
Compare
|
/test |
Artyop
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the feature check is for IPv4 to be enabled, even though the secondary node IPv6 address is configured. This was likely copy-pasted from the section above which does the corresponding configuration of the secondary node IPv4 address. Fix the feature check accordingly to check for IPv6 to be enabled.
Fixes: #35125
Fixes: 8498092 ("connectivity: Add secondary network NodePort tests")