-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Egress masquerade interfaces: type change reverted #36504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the flag declaration back to StringSlice
in daemon/cmd/daemon_main.go
?
I went back and forth a bit on the release note for this. In general PRs should have only one release note label and since this is fixing a regression in v1.17.0-pre.3 I figure that |
9a2772c
to
42b02bf
Compare
Oh, thank you very much! Done. |
/test |
Additionally marking for backport to v1.15, as #36103 got marked as well. |
I agree that if we are backporting #36103 then this should also be backported. I don't understand why we are nominating #36103 however because it's outside the regular backport criteria: https://docs.cilium.io/en/stable/contributing/release/backports/#backport-criteria . CC @nbusseneau Users should be upgrading to the latest stable release if they want all the latest bugfixes. We really should be only backporting critical changes or security fixes to the older releases at this stage, as every change comes with a degree of risk that we break something else in the older releases. The less churn we have on older branches, the less burden we take on as an open source community due to the work of backporting and potentially then also subsequently fixing broken backports on older releases. This translates into more time we can spend making the current stable or next feature release better. |
MasqueradeInterfaces
type reverted to string slice to not break existing users.Also, Viper can do this out of the box.